Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to peggy v4.0.0 #122

Open
hildjj opened this issue Feb 13, 2024 · 5 comments
Open

Update to peggy v4.0.0 #122

hildjj opened this issue Feb 13, 2024 · 5 comments

Comments

@hildjj
Copy link
Contributor

hildjj commented Feb 13, 2024

See release notes here: https://github.com/peggyjs/peggy/releases/tag/v4.0.0

There are a few breaking changes that are likely to hit ts-pegjs. I'm happy to help. Please ping me on the Peggy Discord if you want to chat back and forth.

@pjmolina
Copy link
Contributor

Thank you @hildjj
I will do!

@Josef-Friedrich
Copy link

Any progress? I would be very happy about an update ...

@hildjj
Copy link
Contributor Author

hildjj commented Oct 18, 2024

As a side note, Peggy 4.1 adds support for generating hacked-up .d.ts files next to your .js output with the --dts flag. It's not good, it doesn't do type checking in any way, and it is in no way a replacement for ts-pegjs.

However, it's benn enough to unlock a typescript workflow for me in a couple of projects that need newer Peggy features.

@Josef-Friedrich
Copy link

I use the --dts feature already ... Thank you very much for this feature!

Node wants ./relative-import.js inside the generate parser files in js ... Vitest wants ./relative-import (without extensions) ... maybe I m doing something wrong ...

@hildjj
Copy link
Contributor Author

hildjj commented Oct 18, 2024

This isn't the place to debug that. Can you either hop on the Peggy discord (get invite at https://peggyjs.org) or file a bug on Peggy, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants