Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Always generate .pb.go next to original .proto. #236

Closed
2 tasks done
adamryman opened this issue Sep 12, 2017 · 0 comments
Closed
2 tasks done

Proposal: Always generate .pb.go next to original .proto. #236

adamryman opened this issue Sep 12, 2017 · 0 comments

Comments

@adamryman
Copy link
Member

adamryman commented Sep 12, 2017

  • Update default location of .pb.go to be in the same directory as the .proto definition.
  • Remove flag --pbout

This will update truss such that .pb.go files generated are in line with what the rest of the protoc-gen-go users are doing.

See related comments in #201.

  • Default truss behavior of putting generated .pb.go files into a different directory than the .proto files that defined them. This confuses protoc-gen-go which truss uses to generate the .pb.go files.
  • Proto packages imported in a .proto file used with truss must be imported by their full path relative to $GOPATH/src. This is so that the generated go code will have a proper import path that is buildable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant