Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retract used incorrectly #19

Closed
mgnsk opened this issue Feb 27, 2021 · 1 comment
Closed

Retract used incorrectly #19

mgnsk opened this issue Feb 27, 2021 · 1 comment

Comments

@mgnsk
Copy link
Owner

mgnsk commented Feb 27, 2021

evcache/go.mod

Line 15 in 023b178

retract [v1.0.0, v1.6.0] // race conditions

This only seems to work with versions within the module's major version. There's some ongoing progress to deprecate module versions: golang/go#40357

Maybe it could be done by introducing a separate v2 directory and rolling the root dir back to v1. What happens if all versions within v1 are retracted?

@mgnsk
Copy link
Owner Author

mgnsk commented Mar 7, 2021

The issue seems to be that I can't release a new v1 version which contains the retractions without messing up the repository which I'm not going to do. The project should've used a v2 directory from the beginning so that v1 and v2 could've been updated separately.

Now what could be done is to move the current into v2 directory and checkout the rest from the latest v1 version. Then release a v1 bugfix which retracts all v1 versions. According to retract, it should then jump down to v0.x versions if all v1.x is retracted, can those versions be retracted within the v1 module or will we hit the same problem of not being able to retract v1 versions within v2?

This seems nonsense, I'm fine with having a /v2 in the module name but we should have something to notify v1 users that this version is deprecated.

@mgnsk mgnsk closed this as completed Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant