detect_pitch_in_range can return results outside range

[jangler]

I'm encountering this behavior with HannedFftDetector. I don't know whether it also applies to the other algorithm. Let me know if you need test data!

[mherrerarendon]

Thank you for submitting an issue, @jangler ! Yeah, send me the test data you were using and I can take a look

[jangler]

Thanks! Here's the audio file I encountered the problem with. The range I passed was 20-1046.4 Hz (C6), and the result I got back was 1066 Hz.

banjo.zip

[mherrerarendon]

@jangler
The issue is that the code runs an algorithm to improve the accuracy of the pitch detected, but it does it after the range was constrained, which could skew the result slightly. In your case it shifted it outside of the range.

I think the fix is 2 parts, the algorithm should be run optionally, and there should be some documentation around what the algorithm does and how it's not restrained by the range.

[mherrerarendon]

Adding a new parameter would be a breaking change. I'm going to publish this change along with another branch I already had that also contains breaking changes.