Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate simple systems commands #10

Open
michalfita opened this issue Dec 26, 2023 · 0 comments
Open

Eliminate simple systems commands #10

michalfita opened this issue Dec 26, 2023 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@michalfita
Copy link
Owner

Problem

In multiple places the plugin unnecessary calls commands for file operations, what's bad practice and non-portable solution. Example:

out, err = exec.Command("cp", "-rf", archivePath, dst).CombinedOutput()

Proposal

Replace use of external invocation of standard Unix commands with standard library equivalents of file operations or (when they're missing from API¹) with Go packages.


¹ lack of file copying makes me coming from Rust 🤣

@michalfita michalfita added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 26, 2023
@michalfita michalfita added this to the Reduce OS dependencies milestone Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant