Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many known disposable providers are not present into list #115

Closed
diegodurante opened this issue Apr 24, 2018 · 2 comments
Closed

Many known disposable providers are not present into list #115

diegodurante opened this issue Apr 24, 2018 · 2 comments

Comments

@diegodurante
Copy link
Contributor

Would be great to be aligned with also this json as I can see some domains listed there and not in valid_email2 gem.

For example:

  • daciasandero.tk
  • lg-g7.tk
  • one2mail.info
  • emailure.net
  • uemail99.com
  • yopmail.ml
  • mailsac.tk
    ... and more!
@micke
Copy link
Owner

micke commented Aug 22, 2018

The fastest way is usually to open a PR with the missing domains added.

I try my best to accept PRs in a timely manner and usually cuts a new release the same day of i have time

@cover cover mentioned this issue Oct 4, 2018
Merged
@micke
Copy link
Owner

micke commented Oct 5, 2018

Fixed in #122

@micke micke closed this as completed Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@micke @diegodurante