Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scater argument name update #338

Closed
antagomir opened this issue Feb 3, 2023 · 2 comments
Closed

scater argument name update #338

antagomir opened this issue Feb 3, 2023 · 2 comments
Assignees

Comments

@antagomir
Copy link
Member

The latest development version of the scater package has now switched from exprs_values to assay_name as the argument name, following my recent PR.

I have proposed similar change for scuttle.

It could be expected that the scated update will be added in the Bioc April 2023 devel version.

Action points:

  • update mia package family accordingly
  • update OMA accordingly

Perhaps good to wait until scuttle update (if it is accepted and happens soon) and Bioc devel in April before implementing these changes, so that all dependencies will work more smoothly.

@antagomir
Copy link
Member Author

scuttle does not support assay_name; they use assay.type (and have interesting reasoning for this); see scuttle issue 21

scater now uses assay_name as we do.

I was checking if scater can consider moving to assay.type but currently unresolved scater issue 189.

If scuttle and scater stick to different names, we will need to decide on this. Interoperability with both packages is useful, so we could support both, but have one as the primary argument. Either way.

Of note: the scuttle maintainer is SingleCellExperiment (SCE) author, and TreeSE inherits SCE. In this sense it would be more logical to shift using similar naming scheme than the SCE ecosystem. This could be checked more systematically for other names on the same go. If the changes would seem to be too big to implement, this can be reconsidered but it could be worth having a look.

@antagomir
Copy link
Member Author

antagomir commented Apr 26, 2023

OK, Bioc release is here. We can proceed with this.

Just confirm first that the latest Bioc release indeed includes assay.type argument for scater and scuttle packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants