Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

berkeley: Restore hyperlinks to "Metadata" section and modernize Runtime description #685

Closed
2 tasks done
Tracked by #577
aclum opened this issue Sep 18, 2024 · 4 comments
Closed
2 tasks done
Tracked by #577
Assignees

Comments

@aclum
Copy link
Contributor

aclum commented Sep 18, 2024

  • hyperlinks are not working in the metadata endpoint section (studies, biosamples, planned processes, and data objects)
  • In the main description update 'The NMDC Runtime API, via on-demand functions and via schedule-based and sensor-based automation, supports validation and submission of metadata, as well as orchestration of workflow execution activities.' to 'The NMDC Runtime API, via on-demand functions and via schedule-based and sensor-based automation, supports validation and submission of metadata, as well as orchestration of workflow executions.'
    cc @brynnz22
@eecavanna
Copy link
Collaborator

Thanks for reviewing and reporting those things. I'll fix them after 3pm PT today. @PeopleMakeCulture, you are welcome to implement these fixes in the meantime, in case you happen to be work on this repo between now and then.

@eecavanna
Copy link
Collaborator

I'll fix these now.

@eecavanna
Copy link
Collaborator

eecavanna commented Sep 18, 2024

hyperlinks are not working in the metadata endpoint section (studies, biosamples, planned processes, and data objects)

I looked into this. Those words are, indeed, hyperlinks on the production Runtime (where "activities" is listed instead of "planned processes"). They are not hyperlinks on the Berkeley Runtime (as reported in this Issue).

The are not hyperlinks in the legacy API GUI how-guide (shown below) or the Berkeley API GUI how-to guide (the latter is what I copy/pasted the content from yesterday, for PR #682).

image

So, I assume a Runtime developer added the links to the Runtime by hand at some point. I will do the same now.

@eecavanna eecavanna changed the title berkeley feedback on #682 documentation updates for berkeley berkeley: Restore hyperlinks to "Metadata" section and modernize Runtime description Sep 18, 2024
@eecavanna eecavanna moved this to 👀 In Review in Berkeley-Schema Refactor Roll Out Sep 18, 2024
@eecavanna
Copy link
Collaborator

Fixed in PR #686 (ready for review).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants