Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error serialization when using common-errors #120

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

pajgo
Copy link
Contributor

@pajgo pajgo commented Aug 18, 2021

Fixes errors:

TypeError: Cannot read property 'name' of undefined
    at Object.errSerializer [as err] (/src/node_modules/pino/node_modules/pino-std-serializers/lib/err.js:45:31)
    at Pino.asJson (/src/node_modules/pino/lib/tools.js:122:50)
    at Pino.write (/src/node_modules/pino/lib/proto.js:163:28)
    at Pino.LOG [as error] (/src/node_modules/pino/lib/tools.js:55:21)

@pajgo pajgo requested a review from AVVS August 18, 2021 11:50
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #120 (f796ae3) into master (cbc9598) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   80.18%   80.20%   +0.02%     
==========================================
  Files          14       14              
  Lines         772      773       +1     
  Branches      163      163              
==========================================
+ Hits          619      620       +1     
  Misses        153      153              
Impacted Files Coverage Δ
src/utils/serialization.js 87.50% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbc9598...f796ae3. Read the comment docs.

@AVVS AVVS merged commit 7d5f2a1 into master Aug 18, 2021
@AVVS AVVS deleted the fix/error-serialization-prop-as-fn branch August 18, 2021 15:17
@AVVS
Copy link
Member

AVVS commented Aug 18, 2021

🎉 This PR is included in version 15.2.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AVVS AVVS added the released label Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants