ISSUE-56: correctly handle an unpaired quotes #57
+86
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmlnc
force-pushed
the
issue-56
branch
2 times, most recently
from
a2e5787 to
66da819
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue #56.
I consider the current behavior in the master branch to be a bug, as the package description mentions compatibility with bash.
So I consider this pull-request as a bug fix and do not add any new options.
First of all, I wrote a number of tests because, unfortunately, there were no explicit tests for the quotes. For cases of paired, unpaired, and mixed quotes.
Second, if an unpaired quote occurs in a pattern, I treat it as plain text, not a quote.
P.S. I am confident that we will also face some additional problems after the release. Just because I'm not sure that I've covered all cases. Quotes in bash are a separate kind of art.