Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Checkbox): grow label to container size #190

Merged
merged 2 commits into from
Apr 12, 2022
Merged

feat(Checkbox): grow label to container size #190

merged 2 commits into from
Apr 12, 2022

Conversation

giubatt
Copy link
Contributor

@giubatt giubatt commented Apr 12, 2022

What kind of PR is this?

  • Feature
  • Bug
  • Documentation
  • Other

What is this PR for?

The label element doesn't grow to the size of the checkbox container

How was this achieved?

Added flex-grow: 1 to the component label

What areas of the application does it impact?

Checkbox element

How to test?

Should be able to click on the container where there is no text and check the box

@giubatt giubatt requested a review from VagnerNico April 12, 2022 18:34
@giubatt giubatt self-assigned this Apr 12, 2022
VagnerNico
VagnerNico previously approved these changes Apr 12, 2022
@github-actions
Copy link

github-actions bot commented Apr 12, 2022

Deploy preview for herzui ready!

✅ Preview
https://herzui-81v9dbh8f-micromed.vercel.app

Built with commit 6afd0e5.
This pull request is being automatically deployed with vercel-action

@giubatt giubatt merged commit 70ff8cf into master Apr 12, 2022
@giubatt giubatt deleted the checkbox-grow branch April 12, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants