Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing connectionCount metric in TomcatMetrics #1598

Closed
rafal-dudek opened this issue Sep 23, 2019 · 2 comments
Closed

Missing connectionCount metric in TomcatMetrics #1598

rafal-dudek opened this issue Sep 23, 2019 · 2 comments
Labels
enhancement A general enhancement

Comments

@rafal-dudek
Copy link
Contributor

We have recently found that Micrometer does not expose 'connectionCount' metrics for Tomcat, as a part of the PR: #1595 we also spotted that there is no effective test for metrics derived from 'mBeanServer' (in contrast to Manager object) since invalid metrics name would result in zero value rather than exception during initialization.

@shakuzen
Copy link
Member

we also spotted that there is no effective test for metrics derived from 'mBeanServer' (in contrast to Manager object) since invalid metrics name would result in zero value rather than exception during initialization.

Could you open a separate issue for this, please? That way we don't lose track of that. A pull request would also be greatly appreciated.

@shakuzen shakuzen added the enhancement A general enhancement label Sep 29, 2019
@shakuzen shakuzen added this to the 1.x milestone Sep 29, 2019
@shakuzen shakuzen removed this from the 1.x milestone Oct 29, 2020
@shakuzen
Copy link
Member

This is resolved by #2248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants