Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] FW Define Output values in Porter bundle for shared services #284

Closed
deniscep opened this issue Jun 17, 2021 · 2 comments
Closed

Comments

@deniscep
Copy link
Contributor

deniscep commented Jun 17, 2021

Feature: #23

  • Adjust porter.yaml file to include output in install:, upgrade: and uninstall: blocks (vanilla bundle)
    • Output should at least contain
      • which service it updates (e.g. Firewall)
      • is it create, destroy or update action (is this require - always the desired state for the rules for the requesting resource?)
      • paremeter values relevant for the update of that service in JSON format (e.g. for firewall, there would be "egress": "url;url;url")

https://porter.sh/wiring/#outputs

For example:

{
    ...
    "appEgressRules": [
        // A specific resources firewall app rules.
        {
            "sourceIp": "<10.0.0.1>|<192.168.0.1-192.168.0.5>|<10.2.7.0/24>", //must only be allowed to specify own address space
            "protocol": "TCP"
            "destinationPorts": 
            [
              443,
              80
            ]
            "targetFqdns": [
                "bing.com",
                "msn.com"
            ]
        }
    ],
    "networkEgressRules": [
        // A specific resources firewall app rules.
        {
            "sourceIp": "<10.0.0.1>|<192.168.0.1-192.168.0.5>|<10.2.7.0/24>", //must only be allowed to specify own address space
            "protocol": "TCP"
            "destinationPorts": 
            [
              443,
              80
            ]
            "serviceTags": [
                "AzureContainerRegistry"
            ]
            "targetFqdns": [
                "bing.com",
                "msn.com"
            ]
        }
    ],
},
@tamirkamara
Copy link
Collaborator

@marrobi I think this is now obsolete and should be closed. Can you confirm?

@marrobi
Copy link
Member

marrobi commented Jul 27, 2022

Agree, closing as covered by pipeline work.

@marrobi marrobi closed this as completed Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants