Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable local auth in EventGrid #4254

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Disable local auth in EventGrid #4254

merged 3 commits into from
Feb 5, 2025

Conversation

tamirkamara
Copy link
Collaborator

@tamirkamara tamirkamara commented Jan 6, 2025 •
edited
Loading

Resolves #4253

What is being addressed

Local authentication is on by default in EventGrid.

How is this addressed

  • Disable local auth in both resources
  • Updates to workflows to account for the updated GitHub agents.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025 •
edited
Loading

Unit Test Results

617 tests   617 ✅  6s ⏱️
  2 suites    0 💤
  2 files      0 ❌

Results for commit dd050d7.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12634766851 (with refid 111da09c)

(in response to this comment from @tamirkamara)

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12634766851 (with refid 111da09c)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara force-pushed the tamirkamara/4253-disable-local-auth branch from 47c1adf to 9c0ee44 Compare January 6, 2025 17:12
@tamirkamara tamirkamara changed the title Disable local auth in ServiceBus and EventGrid Disable local auth in EventGrid Jan 6, 2025
@tamirkamara tamirkamara marked this pull request as ready for review January 6, 2025 17:42
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12637465082 (with refid 111da09c)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12645839372 (with refid 111da09c)

(in response to this comment from @tamirkamara)

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12645839372 (with refid 111da09c)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara marked this pull request as draft January 7, 2025 17:50
@tamirkamara tamirkamara force-pushed the tamirkamara/4253-disable-local-auth branch 3 times, most recently from bc88cbe to 408e363 Compare January 19, 2025 14:37
@tamirkamara tamirkamara changed the base branch from main to tamirkamara/function-host-storage-mi January 19, 2025 14:38
@tamirkamara tamirkamara marked this pull request as ready for review January 19, 2025 14:41
@tamirkamara tamirkamara marked this pull request as draft January 19, 2025 14:43
guybartal
guybartal reviewed Jan 20, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
guybartal
guybartal approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@guybartal guybartal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13109623272 (with refid 111da09c)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara force-pushed the tamirkamara/function-host-storage-mi branch from c1bc47f to a596f4c Compare February 5, 2025 05:58
Base automatically changed from tamirkamara/function-host-storage-mi to main February 5, 2025 09:44
@tamirkamara tamirkamara force-pushed the tamirkamara/4253-disable-local-auth branch from 07fc62b to 4284084 Compare February 5, 2025 09:52
@tamirkamara tamirkamara marked this pull request as ready for review February 5, 2025 09:52
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13154664941 (with refid 111da09c)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 18bf385 into main Feb 5, 2025
72 checks passed
@tamirkamara tamirkamara deleted the tamirkamara/4253-disable-local-auth branch February 5, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybartal guybartal guybartal approved these changes

@yuvalyaron yuvalyaron yuvalyaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable local authentication in EventGrid
3 participants
@tamirkamara @guybartal @yuvalyaron