Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: composer doesn't see component dialogs that are in subfolders #6417

Closed
benbrown opened this issue Mar 15, 2021 · 4 comments · Fixed by #6420
Closed

bug: composer doesn't see component dialogs that are in subfolders #6417

benbrown opened this issue Mar 15, 2021 · 4 comments · Fixed by #6420
Assignees
Labels
Area: Components Needs-triage A new issue that require triage Type: Bug Something isn't working

Comments

@benbrown
Copy link
Contributor

Describe the bug

If a component exports multiple dialogs, some of them will live inside subfolders, resulting in an imported structure like:

/dialogs/imported/{Component}/{Dialog}/{Dialog}.dialog

These are currently invisible to composer because the botStructure is only looking 1 folder deep.

See here:

Version

1.4.x

To Reproduce

  1. Simulate a component that has some dialogs in a subfolder by moving some dialogs into an imported folder, such as imported/fakepackage/mydialog/mydialog.dialog
  2. open in composer - you will not see mydialog

Expected behavior

All exported dialogs will be visible to composer

@benbrown benbrown added Type: Bug Something isn't working Needs-triage A new issue that require triage labels Mar 15, 2021
@benbrown
Copy link
Contributor Author

We need to be able to support BOTH:

(root dialog style)
/dialogs/imported/MY-COMPONENT/mydialog.dialog

AND

(child dialog style)
/dialogs/imported/MY-COMPONENT/mydialog/mydialog.dialog

@benbrown
Copy link
Contributor Author

I am not sure how to do this with a glob in such a way that does not result in Composer finding the same file multiple times, causing errors.

@benbrown
Copy link
Contributor Author

@zhixzhan Can you take a look at this please?

@boydc2014
Copy link
Contributor

boydc2014 commented Mar 16, 2021

@benbrown @zhixzhan is out this week, I will take a look at this today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Components Needs-triage A new issue that require triage Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants