Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Web Chat Integration P1 / P2's #6749

Closed
4 of 5 tasks
tonyanziano opened this issue Apr 7, 2021 · 5 comments · Fixed by #6782, #6846 or #7258
Closed
4 of 5 tasks

Additional Web Chat Integration P1 / P2's #6749

tonyanziano opened this issue Apr 7, 2021 · 5 comments · Fixed by #6782, #6846 or #7258

Comments

@tonyanziano
Copy link
Contributor

tonyanziano commented Apr 7, 2021

This is a continuation of #6511 to represent the remaining P1 and P2 work items to be done for the Web Chat integration.

P1's

  • Implement a selected state indicator for the log message currently being shown in the inspector pane
  • Auto-inspect the latest message in the log pane if there is no message currently inspected

P2's

  • Extend debug panel outside of the authoring canvas -- it should be at the same level as the project tree
  • Make the Web Chat panel float above / respect the debug panel
  • Implement status bar (Needs investigation)
@mewa1024
Copy link
Contributor

mewa1024 commented Apr 8, 2021

Can we add another P1? "Enable selecting a message Web Chat to select the corresponding Web Chat log item" like this:

image

Emulator has this behavior.

@tonyanziano
Copy link
Contributor Author

tonyanziano commented Apr 8, 2021

@mewa1024 is there a selected state in Web Chat as well for the activity, or does clicking on an activity just highlight its associated log entry and populate the inspector tab?

Additionally, what if the Web Chat tab is not open. Does it activate the Web Chat tab?

@mewa1024
Copy link
Contributor

@tonyanziano I think the answer to both is yes. I thought Web Chat already had a selected state--clicking a message in the Web Chat pane in Composer looks like this:
image

If the Web Chat pane is not open, is it possible to still select the message so that if the user opens Web Chat, the message will appear in the selected state?

@tonyanziano
Copy link
Contributor Author

@mewa1024 , I think it should be possible, but I'd have to dive into the code a little bit to make sure.

@mewa1024
Copy link
Contributor

mewa1024 commented Jun 1, 2021

Hi, this last part (selected a log message selects the corresponding bubble in Web Chat and vice versa) didn't get in (or reverted back?). Attached is a screen recording showing that selecting the log doesn't not change the selection in Web Chat or vice versa.

Screen.Recording.2021-05-31.at.6.02.53.PM.mov

@tonyanziano @srinaath Can we get this in R14?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment