Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing a bot for the first time through creation of a publishing profile doesn't publish bot to app service #6827

Closed
2 of 8 tasks
darrenj opened this issue Apr 9, 2021 · 4 comments
Assignees
Labels
Area: Publish feature-request A request for new functionality or an enhancement to an existing one. P0 Must Fix. Release-blocker
Milestone

Comments

@darrenj
Copy link

darrenj commented Apr 9, 2021

Describe the bug

When creating a new bot, publishing to Azure through creation of a Publishing profile doesn't appear to push bits onto the App-Service

image

Version

1.4.0.nightly-233315

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Create a new project (basic assistant)
  2. Create a publishing profile and publish
  3. Go to created ABS resource and test in webchat (doesn't work)
  4. go to kudo and inspect published files (none)

Expected behavior

  1. Bot published and works in Azure

Screenshots

Additional context

@pavolum
Copy link
Contributor

pavolum commented Apr 9, 2021

@GeoffCoxMSFT This is expected behavior and proposed solution is deep link outlined in #6836

@Dewain27 Dewain27 added feature-request A request for new functionality or an enhancement to an existing one. and removed Type: Bug Something isn't working labels Apr 16, 2021
@sgellock sgellock added the P0 Must Fix. Release-blocker label May 7, 2021
@sgellock sgellock added this to the R13 milestone May 7, 2021
@sgellock
Copy link
Member

sgellock commented May 7, 2021

Shiproom - @GeoffCoxMSFT can you look at what it would take to add deployment to the create pub profile flow, so we deploy. talk with @benbrown as well, as risk here could be high

@GeoffCoxMSFT
Copy link
Member

We can't put publishing within the provisioning wizard because the provisioning wizard closes when provisioning starts. The server code sends notifications back to main UI. The main UI would have to watch for successful provisioning and detect that it is a new profile. Then it would have to use a special navigation to the publishing page and start the publishing process. In the multi-bot scenario, I don't thing this process would know which bots to select for publishing as we don't know that creating a profile for one bot means that other bots are ready to be published or if the user is really ready to publish the bot with the new profile.

@sgellock sgellock modified the milestones: R13, R14 May 7, 2021
@cwhitten cwhitten assigned Dewain27 and unassigned Dewain27 Jun 7, 2021
@cwhitten
Copy link
Member

cwhitten commented Jun 7, 2021

We've got options here, but before we can move forward on engineering we need an experience review to clarify the UX on initial provision + optional publish. Assigning @Dewain27 to push this forward and moving to R15 for now.

@cwhitten cwhitten assigned Dewain27 and unassigned GeoffCoxMSFT Jun 7, 2021
@cwhitten cwhitten removed this from the R14 milestone Jun 7, 2021
@cwhitten cwhitten added this to the R15 milestone Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Publish feature-request A request for new functionality or an enhancement to an existing one. P0 Must Fix. Release-blocker
Projects
None yet
Development

No branches or pull requests

6 participants