Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Blank Bot" template created bot called "empty" #6978

Closed
2 of 8 tasks
cleemullins opened this issue Apr 14, 2021 · 4 comments · Fixed by #7378
Closed
2 of 8 tasks

"Blank Bot" template created bot called "empty" #6978

cleemullins opened this issue Apr 14, 2021 · 4 comments · Fixed by #7378
Assignees
Labels
Blocked P1 Painful if we don't fix, won't block releasing R13 Bugbash topic: creation Type: Bug Something isn't working UX Design Need UX Design
Milestone

Comments

@cleemullins
Copy link

Describe the bug

Create a new bot, selecting the "Blank Bot" template.

On the next screen (see screen shot), the default bot name is "empty". I would expect this to be "blank". Having the name default to "empty" doesn't seem correct.

Version

Version: 1.4.0-nightly.235171.cfc0c11
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Click on "Create a new bot"
  2. Select the "Blank Bot" template
  3. Observe the name of your new bot is "empty"
  4. Wonder what "empty" was?

Expected behavior

I would expect my bot to be name "blank". Although, truth be told, that's not a great default name.

Screenshots

image

image

@clearab
Copy link

clearab commented Apr 15, 2021

@pavolum I believe this is going to revert to the 'empty bot' template, however, I'm uncertain where the default naming for templates is being created/pulled from. If we open templates up to 3rd parties, how is the default name going to be populated?

@clearab clearab added P1 Painful if we don't fix, won't block releasing and removed Needs-triage A new issue that require triage labels Apr 15, 2021
@clearab
Copy link

clearab commented Apr 15, 2021

Leaving this open, but resolution is blocked until naming is finalized (although my question above may present the possibility of an alternative solution, not sure)

@pavolum
Copy link
Contributor

pavolum commented Apr 21, 2021

@clearab when will naming for templates be finalized?

Two aspects to this issue

  • Display name needing to be changed - display name is now pulled from an external source so we can change that outside of composer releases. If that call to the external source fails it uses the hard coded names in Composer as a back up so the PR Chris had added here is still valid assuming his change to call it 'blank bot' reflects the final naming decision
  • The default name autopopulated for your bot proj is not a one to one match to the template name itself. This is known and will not be fixes in R13

@pavolum
Copy link
Contributor

pavolum commented Apr 21, 2021

Okay renaming of generators is tracked here:
microsoft/botframework-components#932

This requires both a Composer and Components repo change. Peter and I are in communication and will have this resolved Friday when they push new RCs. Keeping this open for tracking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked P1 Painful if we don't fix, won't block releasing R13 Bugbash topic: creation Type: Bug Something isn't working UX Design Need UX Design
Projects
None yet
5 participants