Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Page MRU list has confusing sort order visuals and behavior #7110

Closed
2 of 8 tasks
sgellock opened this issue Apr 19, 2021 · 2 comments · Fixed by #7140
Closed
2 of 8 tasks

Home Page MRU list has confusing sort order visuals and behavior #7110

sgellock opened this issue Apr 19, 2021 · 2 comments · Fixed by #7140
Assignees
Labels

Comments

@sgellock
Copy link
Member

Describe the bug

The sort order for the MRU list of previously opened bots has misleading UI. See screenshot for visuals.

I'm not exactly sure what drives the MRU list sort order. It's not recently opened. Which is should be. This list should be sorted by most recently opened. This is the way office products work. This is the way Visual Studio works.

also, there are headers for this list that indicate the list can be sorted by other columns. This isn't the case.

Lastly, the Name column has a sort icon displayed, and this isn't accurate, as the list isn't sorted by name.

Version

Version: 1.4.0-nightly.236490.3735dd3
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. launch Composer
  2. Note the MRU header indicates that list is sorted by name. It actually isn't.
  3. Click on the headers of the MRU list, note they indicate they should be sortable, though they are not.
  4. Open a previous bot project that is not the first project in the list.
  5. Click the Home icon in the left hand nav to return to the home page. Note the bot project you opened is not at the top of the MRU list, though is is the Most Recently Used project

Expected behavior

I would expect the MRU list to behave as other Microsoft MRU lists, e.g. Word, Visual Studio, etc.

I would also expect the headers to not be sortable, and therefore not clickable

I would expect the up arrow icon for the Name column to go away, as we don't sort by Name.

Screenshots

Screen Shot 2021-04-19 at 12 25 28 PM

@sgellock sgellock added Type: Bug Something isn't working Needs-triage A new issue that require triage labels Apr 19, 2021
@mewa1024
Copy link
Contributor

Agree with the 3 expected behaviors above.
(Adding @xiyangdesign as fyi)

@zhixzhan
Copy link
Contributor

Hi @mewa1024, I found it's because recent bot list did not render again. it should be fixed by #7140.

@cwhitten cwhitten removed the Needs-triage A new issue that require triage label Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants