Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed Callers is not editable when making a bot available as a skill #7147

Closed
2 of 8 tasks
darrenj opened this issue Apr 20, 2021 · 2 comments · Fixed by #7361
Closed
2 of 8 tasks

Allowed Callers is not editable when making a bot available as a skill #7147

darrenj opened this issue Apr 20, 2021 · 2 comments · Fixed by #7361
Assignees
Labels
P1 Painful if we don't fix, won't block releasing Skills Workflow topic: skill Type: Bug Something isn't working
Milestone

Comments

@darrenj
Copy link

darrenj commented Apr 20, 2021

Describe the bug

When making a Bot available as a skill the allowed callers UX enables you to add allowed callers but clicking "add allowed callers" just adds a non-editable 0000-11111-00000-111111 entry

image

Version

1.4.0-nightly.237101

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Create a bot, add LUIS/trigger
  2. choose make bot available as a skill
  3. work through screens to add allowed callers, observe that adding a new one isn't editable

Expected behavior

Editable allowed callers, also a link to further documentation that explains how skills work and why allowed callers is needed.

@darrenj darrenj added Type: Bug Something isn't working Needs-triage A new issue that require triage labels Apr 20, 2021
@tdurnford tdurnford added this to the R13 milestone Apr 20, 2021
@tdurnford
Copy link
Collaborator

tdurnford commented Apr 20, 2021

@darrenj It looks like you can edit it - the field is just borderless. Not sure why the value defaults to '0000-11111-00000-11111' - that is a very strange and confusing behavior.

I don't think we should use the borderless prop here. When the user hovers over the value, it's not clear the text is actually a text field. This should behave exactly like the Allowed Callers component in the settings. When the user hovers over the field, borders should appear around the text to indicate that it is an editable field. Also, when the user hits the 'Add new caller' button, we should set the focus to the newest entry.

Screen capture - bot settings

Apr-20-2021 13-51-24

@cwhitten cwhitten removed the Needs-triage A new issue that require triage label Apr 20, 2021
@cwhitten
Copy link
Member

@luhan2017 I agree with @tdurnford. Let's use existing patterns here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Painful if we don't fix, won't block releasing Skills Workflow topic: skill Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants