Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth prompt by Composer after creating an empty bot template #7591

Closed
2 of 8 tasks
darrenj opened this issue May 4, 2021 · 3 comments
Closed
2 of 8 tasks

Auth prompt by Composer after creating an empty bot template #7591

darrenj opened this issue May 4, 2021 · 3 comments
Assignees
@VamsiModem
Labels
P0 Must Fix. Release-blocker ShipRoom-Approved Ship room has approved this issue for the release topic: creation Type: Bug Something isn't working
Milestone
R13

Comments

@darrenj
Copy link

darrenj commented May 4, 2021 •
edited
Loading

Describe the bug

When creating an empty bot (no azure resource dependencies) Composer prompts for authentication.

Also note that when clicking Cancel, it prompts again? Cancelling the 2nd prompt enables you to continue.

Version

2.0.0-nightly.242275

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Create Empty Bot
  2. Observe Auth prompt after creation

Expected behavior

No auth prompt

Screenshots

image
@darrenj darrenj added Type: Bug Something isn't working Needs-triage A new issue that require triage P0 Must Fix. Release-blocker labels May 4, 2021
@darrenj darrenj added this to the R13 milestone May 4, 2021
@Dewain27 Dewain27 added topic: creation and removed Needs-triage A new issue that require triage labels May 4, 2021
@benbrown
Copy link
Contributor

benbrown commented May 4, 2021

I believe this is due to the auth being called when the ManagerService components mount as part of the getstarted component.

https://github.com/microsoft/BotFramework-Composer/blame/4fd58c86e6038ac1c33432814839dac4754cfb4b/Composer/packages/client/src/components/ManageService/ManageService.tsx#L162

@sgellock
Copy link
Member

sgellock commented May 4, 2021

Shiproom - this is a regression, P0. approved.

@sgellock sgellock added the ShipRoom-Approved Ship room has approved this issue for the release label May 4, 2021
@benbrown
Copy link
Contributor

benbrown commented May 4, 2021

fixed by #7623

@benbrown benbrown closed this as completed May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VamsiModem VamsiModem

Labels
P0 Must Fix. Release-blocker ShipRoom-Approved Ship room has approved this issue for the release topic: creation Type: Bug Something isn't working
Projects
None yet
Milestone
R13
Development

No branches or pull requests
5 participants
@benbrown @sgellock @VamsiModem @Dewain27 @darrenj