From 2cc4ccd003d2c06df6f2d57722ebd82c17026a64 Mon Sep 17 00:00:00 2001 From: Ben Brown Date: Wed, 21 Apr 2021 13:40:47 -0500 Subject: [PATCH 01/12] add telemetry events for new qna, luis and speech flows. add additional telemetry to get started. --- .../GetStarted/GetStartedNextSteps.tsx | 9 +++++++ .../src/components/ManageQNA/ManageQNA.tsx | 1 + .../ManageService/ManageService.tsx | 24 +++++++++++++++++++ .../recoilModel/dispatchers/provisionQNA.ts | 7 ++++++ Composer/packages/types/src/telemetry.ts | 15 ++++++++++++ 5 files changed, 56 insertions(+) diff --git a/Composer/packages/client/src/components/GetStarted/GetStartedNextSteps.tsx b/Composer/packages/client/src/components/GetStarted/GetStartedNextSteps.tsx index 17c7745a12..030a7d43f8 100644 --- a/Composer/packages/client/src/components/GetStarted/GetStartedNextSteps.tsx +++ b/Composer/packages/client/src/components/GetStarted/GetStartedNextSteps.tsx @@ -125,6 +125,7 @@ export const GetStartedNextSteps: React.FC = (props) => { setHighlightLUIS(true); }, onClick: (step) => { + TelemetryClient.track('GettingStartedActionClicked', { taskName: 'luis', priority: 'required' }); openLink(linkToLUISSettings); if (!step?.checked) { setDisplayManageLuis(true); @@ -144,6 +145,7 @@ export const GetStartedNextSteps: React.FC = (props) => { setHighlightQNA(true); }, onClick: (step) => { + TelemetryClient.track('GettingStartedActionClicked', { taskName: 'qna', priority: 'required' }); openLink(linktoQNASettings); if (!step?.checked) { setDisplayManageQNA(true); @@ -165,6 +167,7 @@ export const GetStartedNextSteps: React.FC = (props) => { required: true, checked: hasPublishingProfile, onClick: (step) => { + TelemetryClient.track('GettingStartedActionClicked', { taskName: 'publishing', priority: 'recommended' }); openLink(linkToPublishProfile); }, }); @@ -179,6 +182,7 @@ export const GetStartedNextSteps: React.FC = (props) => { learnMore: '', checked: false, onClick: () => { + TelemetryClient.track('GettingStartedActionClicked', { taskName: 'packages', priority: 'optional' }); openLink(linkToPackageManager); }, }, @@ -189,6 +193,7 @@ export const GetStartedNextSteps: React.FC = (props) => { learnMore: '', checked: false, onClick: () => { + TelemetryClient.track('GettingStartedActionClicked', { taskName: 'editlg', priority: 'optional' }); openLink(linkToLGEditor); }, }, @@ -199,6 +204,7 @@ export const GetStartedNextSteps: React.FC = (props) => { learnMore: '', checked: false, onClick: () => { + TelemetryClient.track('GettingStartedActionClicked', { taskName: 'editlu', priority: 'optional' }); openLink(linkToLUEditor); }, }, @@ -211,6 +217,7 @@ export const GetStartedNextSteps: React.FC = (props) => { learnMore: '', checked: false, onClick: () => { + TelemetryClient.track('GettingStartedActionClicked', { taskName: 'insights', priority: 'optional' }); openLink(linkToAppInsights); }, }, @@ -221,6 +228,7 @@ export const GetStartedNextSteps: React.FC = (props) => { learnMore: '', checked: false, onClick: () => { + TelemetryClient.track('GettingStartedActionClicked', { taskName: 'devops', priority: 'optional' }); openLink(linkToDevOps); }, }, @@ -234,6 +242,7 @@ export const GetStartedNextSteps: React.FC = (props) => { learnMore: '', checked: false, onClick: () => { + TelemetryClient.track('GettingStartedActionClicked', { taskName: 'connections', priority: 'optional' }); openLink(linkToConnections); }, }); diff --git a/Composer/packages/client/src/components/ManageQNA/ManageQNA.tsx b/Composer/packages/client/src/components/ManageQNA/ManageQNA.tsx index bdcb525661..b52ccf2cd4 100644 --- a/Composer/packages/client/src/components/ManageQNA/ManageQNA.tsx +++ b/Composer/packages/client/src/components/ManageQNA/ManageQNA.tsx @@ -11,6 +11,7 @@ import { dispatcherState } from '../../recoilModel'; import { ManageService } from '../ManageService/ManageService'; import { currentProjectIdState } from '../../recoilModel'; import { rootBotProjectIdSelector } from '../../recoilModel/selectors/project'; +import TelemetryClient from '../../telemetry/TelemetryClient'; const QNA_REGIONS = [{ key: 'westus', text: 'westus' }]; diff --git a/Composer/packages/client/src/components/ManageService/ManageService.tsx b/Composer/packages/client/src/components/ManageService/ManageService.tsx index a61f83eb68..4c73afad24 100644 --- a/Composer/packages/client/src/components/ManageService/ManageService.tsx +++ b/Composer/packages/client/src/components/ManageService/ManageService.tsx @@ -23,6 +23,7 @@ import { ProvisionHandoff } from '@bfc/ui-shared'; import sortBy from 'lodash/sortBy'; import { NeutralColors } from '@uifabric/fluent-theme'; +import TelemetryClient from '../../telemetry/TelemetryClient'; import { AuthClient } from '../../utils/authClient'; import { AuthDialog } from '../../components/Auth/AuthDialog'; import { armScopes } from '../../constants'; @@ -255,6 +256,13 @@ export const ManageService = (props: ManageServiceProps) => { } } + TelemetryClient.track('SettingsGetKeysCreateNewResourceStarted', { + subscriptionId, + region, + resourceType: props.serviceName, + createNewResourceGroup: resourceGroupKey === CREATE_NEW_KEY, + }); + try { if (props.createServiceInBackground) { props.createService(tokenCredentials, subscriptionId, resourceGroupName, resourceName, region); @@ -267,6 +275,13 @@ export const ManageService = (props: ManageServiceProps) => { region ); + TelemetryClient.track('SettingsGetKeysCreateNewResourceCompleted', { + subscriptionId, + region, + resourceType: props.serviceName, + createNewResourceGroup: resourceGroupKey === CREATE_NEW_KEY, + }); + setKey(newKey); // ALL DONE! // this will pass the new values back to the caller @@ -356,6 +371,11 @@ export const ManageService = (props: ManageServiceProps) => { }; const chooseExistingKey = () => { + TelemetryClient.track('SettingsGetKeysExistingResourceSelected', { + subscriptionId, + resourceType: props.serviceName, + }); + // close the modal! props.onGetKey({ key: key, @@ -385,6 +405,10 @@ export const ManageService = (props: ManageServiceProps) => { const performNextAction = () => { if (nextAction === 'handoff') { + TelemetryClient.track('SettingsGetKeysResourceRequestSelected', { + subscriptionId, + resourceType: props.serviceName, + }); setShowHandoff(true); props.onDismiss(); } else { diff --git a/Composer/packages/client/src/recoilModel/dispatchers/provisionQNA.ts b/Composer/packages/client/src/recoilModel/dispatchers/provisionQNA.ts index 5f791b280e..5e6e23abbf 100644 --- a/Composer/packages/client/src/recoilModel/dispatchers/provisionQNA.ts +++ b/Composer/packages/client/src/recoilModel/dispatchers/provisionQNA.ts @@ -9,6 +9,7 @@ import { SearchManagementClient } from '@azure/arm-search'; import { WebSiteManagementClient } from '@azure/arm-appservice'; import { ApplicationInsightsManagementClient } from '@azure/arm-appinsights'; +import TelemetryClient from '../../telemetry/TelemetryClient'; import { getCompletedQNANotificationCardProps, getPendingQNANotificationCardProps, @@ -208,6 +209,12 @@ export const provisionQNADispatcher = () => { }); settingStorage.setField(projectId, 'qna.endpointKey', endpointKey); + TelemetryClient.track('SettingsGetKeysCreateNewResourceCompleted', { + subscriptionId, + region, + resourceType: 'QnA Maker', + }); + deleteNotificationInternal(callbackHelpers, notification.id); const timeElapsed = Math.floor((new Date().getTime() - startTime) / (60 * 1000)); const completedNotification = createNotification(getCompletedQNANotificationCardProps({ time: timeElapsed })); diff --git a/Composer/packages/types/src/telemetry.ts b/Composer/packages/types/src/telemetry.ts index 9802bdd5f0..e58ef8a58e 100644 --- a/Composer/packages/types/src/telemetry.ts +++ b/Composer/packages/types/src/telemetry.ts @@ -44,6 +44,7 @@ type ApplicationEvents = { type GettingStartedEvents = { GettingStartedLinkClicked: { method: 'link' | 'button'; url: string }; + GettingStartedActionClicked: { taskName: string; priority: string }; }; type PackageManagerEvents = { @@ -121,6 +122,20 @@ type AppSettingsEvents = { type BotSettingsEvents = { CustomRuntimeToggleChanged: { enabled: boolean }; GetNewRuntime: { runtimeType: string }; + SettingsGetKeysExistingResourceSelected: { subscriptionId: string; resourceType: string }; + SettingsGetKeysCreateNewResourceStarted: { + subscriptionId: string; + resourceType: string; + createNewResourceGroup: boolean; + region: string; + }; + SettingsGetKeysCreateNewResourceCompleted: { + subscriptionId: string; + resourceType: string; + createNewResourceGroup: boolean; + region: string; + }; + SettingsGetKeysResourceRequestSelected: { subscriptionId?: string; resourceType: string }; }; type LgEditorEvents = { From 22691c663b088d7824cdc5e9c0027bbf0601e4a5 Mon Sep 17 00:00:00 2001 From: Ben Brown Date: Wed, 21 Apr 2021 16:11:45 -0500 Subject: [PATCH 02/12] add additional telemetry calls to the provisioning process --- Composer/packages/types/src/telemetry.ts | 18 +++++++++++++ .../src/components/azureProvisionDialog.tsx | 25 ++++++++++++++++++- 2 files changed, 42 insertions(+), 1 deletion(-) diff --git a/Composer/packages/types/src/telemetry.ts b/Composer/packages/types/src/telemetry.ts index e58ef8a58e..5707c8255c 100644 --- a/Composer/packages/types/src/telemetry.ts +++ b/Composer/packages/types/src/telemetry.ts @@ -108,11 +108,29 @@ type QnaEvents = { AlternateQnAPhraseAdded: undefined; }; +type ResourcesItem = { + description: string; + text: string; + tier: string; + group: string; + key: string; + required: boolean; + [key: string]: any; +}; + type PublishingEvents = { NewPublishingProfileStarted: undefined; NewPublishingProfileSaved: { type: string; msAppId?: string; subscriptionId?: string }; PublishingProfileStarted: { target: string; projectId: string; msAppId?: string; subscriptionId?: string }; PublishingProfileCompleted: { target: string; projectId: string; msAppId?: string; subscriptionId?: string }; + ProvisionAddResources: undefined; + ProvisionConfigureResources: undefined; + ProvisionEditJSON: undefined; + ProvisionReviewResources: undefined; + ProvisionStart: { region: string; subscriptionId: string; externalResources: ResourcesItem[] }; + ProvisionCancel: undefined; + ProvisionShowHandoff: undefined; + ProvisionAddResourcesCancel: undefined; }; type AppSettingsEvents = { diff --git a/extensions/azurePublish/src/components/azureProvisionDialog.tsx b/extensions/azurePublish/src/components/azureProvisionDialog.tsx index b45538d025..bf07a17b45 100644 --- a/extensions/azurePublish/src/components/azureProvisionDialog.tsx +++ b/extensions/azurePublish/src/components/azureProvisionDialog.tsx @@ -6,7 +6,15 @@ import styled from '@emotion/styled'; import { useState, useMemo, useEffect, Fragment, useCallback, useRef } from 'react'; import { Dropdown, IDropdownOption } from 'office-ui-fabric-react/lib/Dropdown'; import { DefaultButton, PrimaryButton } from 'office-ui-fabric-react/lib/Button'; -import { logOut, usePublishApi, getTenants, getARMTokenForTenant, useLocalStorage } from '@bfc/extension-client'; +import { + logOut, + usePublishApi, + getTenants, + getARMTokenForTenant, + useLocalStorage, + useTelemetryClient, + TelemetryClient, +} from '@bfc/extension-client'; import { Subscription } from '@azure/arm-subscriptions/esm/models'; import { DeployLocation, AzureTenant } from '@botframework-composer/types'; import { FluentTheme, NeutralColors } from '@uifabric/fluent-theme'; @@ -258,6 +266,7 @@ export const AzureProvisionDialog: React.FC = () => { getTenantIdFromCache, setTenantId, } = usePublishApi(); + const telemetryClient: TelemetryClient = useTelemetryClient(); const { setItem, getItem, clearAll } = useLocalStorage(); // set type of publish - azurePublish or azureFunctionsPublish @@ -337,18 +346,22 @@ export const AzureProvisionDialog: React.FC = () => { setPage(page); switch (page) { case PageTypes.AddResources: + telemetryClient.track('ProvisionAddResources', {}); setTitle(DialogTitle.ADD_RESOURCES); break; case PageTypes.ChooseAction: setTitle(DialogTitle.CHOOSE_ACTION); break; case PageTypes.ConfigProvision: + telemetryClient.track('ProvisionConfigureResources', {}); setTitle(DialogTitle.CONFIG_RESOURCES); break; case PageTypes.EditJson: + telemetryClient.track('ProvisionEditJSON', {}); setTitle(DialogTitle.EDIT); break; case PageTypes.ReviewResource: + telemetryClient.track('ProvisionReviewResources', {}); setTitle(DialogTitle.REVIEW); break; } @@ -671,6 +684,13 @@ export const AzureProvisionDialog: React.FC = () => { const onSubmit = useCallback((options) => { // call back to the main Composer API to begin this process... + + telemetryClient.track('ProvisionStart', { + region: options.location, + subscriptionId: options.subscription, + externalResources: options.externalResources, + }); + startProvision(options); clearAll(); closeDialog(); @@ -941,6 +961,7 @@ export const AzureProvisionDialog: React.FC = () => { style={{ margin: '0 4px' }} text={formatMessage('Cancel')} onClick={() => { + telemetryClient.track('ProvisionCancel', {}); closeDialog(); }} /> @@ -1036,6 +1057,7 @@ export const AzureProvisionDialog: React.FC = () => { text={formatMessage('Next')} onClick={() => { if (formData.creationType === 'generate') { + telemetryClient.track('ProvisionShowHandoff', {}); setShowHandoff(true); } else { setPageAndTitle(PageTypes.ReviewResource); @@ -1059,6 +1081,7 @@ export const AzureProvisionDialog: React.FC = () => { style={{ margin: '0 4px' }} text={formatMessage('Cancel')} onClick={() => { + telemetryClient.track('ProvisionAddResourcesCancel', {}); closeDialog(); }} /> From 37f9f56a00fa8f3fd355c51919bd66428faeb552 Mon Sep 17 00:00:00 2001 From: Ben Brown Date: Wed, 21 Apr 2021 16:13:51 -0500 Subject: [PATCH 03/12] remove some unused imports --- Composer/packages/client/src/components/ManageQNA/ManageQNA.tsx | 1 - .../packages/client/src/recoilModel/dispatchers/provisionQNA.ts | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/Composer/packages/client/src/components/ManageQNA/ManageQNA.tsx b/Composer/packages/client/src/components/ManageQNA/ManageQNA.tsx index b52ccf2cd4..bdcb525661 100644 --- a/Composer/packages/client/src/components/ManageQNA/ManageQNA.tsx +++ b/Composer/packages/client/src/components/ManageQNA/ManageQNA.tsx @@ -11,7 +11,6 @@ import { dispatcherState } from '../../recoilModel'; import { ManageService } from '../ManageService/ManageService'; import { currentProjectIdState } from '../../recoilModel'; import { rootBotProjectIdSelector } from '../../recoilModel/selectors/project'; -import TelemetryClient from '../../telemetry/TelemetryClient'; const QNA_REGIONS = [{ key: 'westus', text: 'westus' }]; diff --git a/Composer/packages/client/src/recoilModel/dispatchers/provisionQNA.ts b/Composer/packages/client/src/recoilModel/dispatchers/provisionQNA.ts index 5e6e23abbf..09387a67dd 100644 --- a/Composer/packages/client/src/recoilModel/dispatchers/provisionQNA.ts +++ b/Composer/packages/client/src/recoilModel/dispatchers/provisionQNA.ts @@ -212,6 +212,7 @@ export const provisionQNADispatcher = () => { TelemetryClient.track('SettingsGetKeysCreateNewResourceCompleted', { subscriptionId, region, + createNewResourceGroup: false, resourceType: 'QnA Maker', }); From b4aacb6de654d3cd18dfc9a264f5a587a5317285 Mon Sep 17 00:00:00 2001 From: Ben Brown Date: Wed, 21 Apr 2021 16:24:01 -0500 Subject: [PATCH 04/12] Update extensions/azurePublish/src/components/azureProvisionDialog.tsx Co-authored-by: TJ Durnford --- extensions/azurePublish/src/components/azureProvisionDialog.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/azurePublish/src/components/azureProvisionDialog.tsx b/extensions/azurePublish/src/components/azureProvisionDialog.tsx index bf07a17b45..a208c630e9 100644 --- a/extensions/azurePublish/src/components/azureProvisionDialog.tsx +++ b/extensions/azurePublish/src/components/azureProvisionDialog.tsx @@ -1081,7 +1081,7 @@ export const AzureProvisionDialog: React.FC = () => { style={{ margin: '0 4px' }} text={formatMessage('Cancel')} onClick={() => { - telemetryClient.track('ProvisionAddResourcesCancel', {}); + telemetryClient.track('ProvisionAddResourcesCancel'); closeDialog(); }} /> From 830edcde04275480f98c58132611e92297942d45 Mon Sep 17 00:00:00 2001 From: Ben Brown Date: Wed, 21 Apr 2021 16:24:14 -0500 Subject: [PATCH 05/12] Update extensions/azurePublish/src/components/azureProvisionDialog.tsx Co-authored-by: TJ Durnford --- extensions/azurePublish/src/components/azureProvisionDialog.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/azurePublish/src/components/azureProvisionDialog.tsx b/extensions/azurePublish/src/components/azureProvisionDialog.tsx index a208c630e9..613d16d622 100644 --- a/extensions/azurePublish/src/components/azureProvisionDialog.tsx +++ b/extensions/azurePublish/src/components/azureProvisionDialog.tsx @@ -346,7 +346,7 @@ export const AzureProvisionDialog: React.FC = () => { setPage(page); switch (page) { case PageTypes.AddResources: - telemetryClient.track('ProvisionAddResources', {}); + telemetryClient.track('ProvisionAddResources'); setTitle(DialogTitle.ADD_RESOURCES); break; case PageTypes.ChooseAction: From 8f224b9b5e1470b1e5bfbeae0d41091d8e27e51a Mon Sep 17 00:00:00 2001 From: Ben Brown Date: Wed, 21 Apr 2021 16:24:21 -0500 Subject: [PATCH 06/12] Update extensions/azurePublish/src/components/azureProvisionDialog.tsx Co-authored-by: TJ Durnford --- extensions/azurePublish/src/components/azureProvisionDialog.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/azurePublish/src/components/azureProvisionDialog.tsx b/extensions/azurePublish/src/components/azureProvisionDialog.tsx index 613d16d622..d66bb553a0 100644 --- a/extensions/azurePublish/src/components/azureProvisionDialog.tsx +++ b/extensions/azurePublish/src/components/azureProvisionDialog.tsx @@ -1057,7 +1057,7 @@ export const AzureProvisionDialog: React.FC = () => { text={formatMessage('Next')} onClick={() => { if (formData.creationType === 'generate') { - telemetryClient.track('ProvisionShowHandoff', {}); + telemetryClient.track('ProvisionShowHandoff'); setShowHandoff(true); } else { setPageAndTitle(PageTypes.ReviewResource); From 85399371cb4f2a3d2d57ef85cd2c8ba609047dab Mon Sep 17 00:00:00 2001 From: Ben Brown Date: Wed, 21 Apr 2021 16:24:27 -0500 Subject: [PATCH 07/12] Update extensions/azurePublish/src/components/azureProvisionDialog.tsx Co-authored-by: TJ Durnford --- extensions/azurePublish/src/components/azureProvisionDialog.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/azurePublish/src/components/azureProvisionDialog.tsx b/extensions/azurePublish/src/components/azureProvisionDialog.tsx index d66bb553a0..bf5aedae16 100644 --- a/extensions/azurePublish/src/components/azureProvisionDialog.tsx +++ b/extensions/azurePublish/src/components/azureProvisionDialog.tsx @@ -961,7 +961,7 @@ export const AzureProvisionDialog: React.FC = () => { style={{ margin: '0 4px' }} text={formatMessage('Cancel')} onClick={() => { - telemetryClient.track('ProvisionCancel', {}); + telemetryClient.track('ProvisionCancel'); closeDialog(); }} /> From 8344efbac1698af3463a31b4eaad496ac6db7016 Mon Sep 17 00:00:00 2001 From: Ben Brown Date: Wed, 21 Apr 2021 16:24:39 -0500 Subject: [PATCH 08/12] Update extensions/azurePublish/src/components/azureProvisionDialog.tsx Co-authored-by: TJ Durnford --- extensions/azurePublish/src/components/azureProvisionDialog.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/azurePublish/src/components/azureProvisionDialog.tsx b/extensions/azurePublish/src/components/azureProvisionDialog.tsx index bf5aedae16..4e0239d4c5 100644 --- a/extensions/azurePublish/src/components/azureProvisionDialog.tsx +++ b/extensions/azurePublish/src/components/azureProvisionDialog.tsx @@ -361,7 +361,7 @@ export const AzureProvisionDialog: React.FC = () => { setTitle(DialogTitle.EDIT); break; case PageTypes.ReviewResource: - telemetryClient.track('ProvisionReviewResources', {}); + telemetryClient.track('ProvisionReviewResources'); setTitle(DialogTitle.REVIEW); break; } From 9fa0ae031edaa8d1ee28176af560c796de42302c Mon Sep 17 00:00:00 2001 From: Ben Brown Date: Wed, 21 Apr 2021 16:24:46 -0500 Subject: [PATCH 09/12] Update extensions/azurePublish/src/components/azureProvisionDialog.tsx Co-authored-by: TJ Durnford --- extensions/azurePublish/src/components/azureProvisionDialog.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/azurePublish/src/components/azureProvisionDialog.tsx b/extensions/azurePublish/src/components/azureProvisionDialog.tsx index 4e0239d4c5..4dccf19234 100644 --- a/extensions/azurePublish/src/components/azureProvisionDialog.tsx +++ b/extensions/azurePublish/src/components/azureProvisionDialog.tsx @@ -357,7 +357,7 @@ export const AzureProvisionDialog: React.FC = () => { setTitle(DialogTitle.CONFIG_RESOURCES); break; case PageTypes.EditJson: - telemetryClient.track('ProvisionEditJSON', {}); + telemetryClient.track('ProvisionEditJSON'); setTitle(DialogTitle.EDIT); break; case PageTypes.ReviewResource: From 51806b46b0c948ca5780e17d87b85030867419e2 Mon Sep 17 00:00:00 2001 From: Ben Brown Date: Wed, 21 Apr 2021 16:24:52 -0500 Subject: [PATCH 10/12] Update extensions/azurePublish/src/components/azureProvisionDialog.tsx Co-authored-by: TJ Durnford --- extensions/azurePublish/src/components/azureProvisionDialog.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/azurePublish/src/components/azureProvisionDialog.tsx b/extensions/azurePublish/src/components/azureProvisionDialog.tsx index 4dccf19234..52ca515ff1 100644 --- a/extensions/azurePublish/src/components/azureProvisionDialog.tsx +++ b/extensions/azurePublish/src/components/azureProvisionDialog.tsx @@ -353,7 +353,7 @@ export const AzureProvisionDialog: React.FC = () => { setTitle(DialogTitle.CHOOSE_ACTION); break; case PageTypes.ConfigProvision: - telemetryClient.track('ProvisionConfigureResources', {}); + telemetryClient.track('ProvisionConfigureResources'); setTitle(DialogTitle.CONFIG_RESOURCES); break; case PageTypes.EditJson: From bbcaa2899a275f204782a90df2bd81e3be7a0c2c Mon Sep 17 00:00:00 2001 From: Ben Brown Date: Wed, 21 Apr 2021 16:42:44 -0500 Subject: [PATCH 11/12] change name of event to ProvisionAddResourcesNavigate --- Composer/packages/types/src/telemetry.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Composer/packages/types/src/telemetry.ts b/Composer/packages/types/src/telemetry.ts index 5707c8255c..c13d79ed0c 100644 --- a/Composer/packages/types/src/telemetry.ts +++ b/Composer/packages/types/src/telemetry.ts @@ -123,7 +123,7 @@ type PublishingEvents = { NewPublishingProfileSaved: { type: string; msAppId?: string; subscriptionId?: string }; PublishingProfileStarted: { target: string; projectId: string; msAppId?: string; subscriptionId?: string }; PublishingProfileCompleted: { target: string; projectId: string; msAppId?: string; subscriptionId?: string }; - ProvisionAddResources: undefined; + ProvisionAddResourcesNavigate: undefined; ProvisionConfigureResources: undefined; ProvisionEditJSON: undefined; ProvisionReviewResources: undefined; From fcf1ab024a3cdb314363062ff55858707a3d3b61 Mon Sep 17 00:00:00 2001 From: Ben Brown Date: Wed, 21 Apr 2021 16:44:17 -0500 Subject: [PATCH 12/12] rename event --- extensions/azurePublish/src/components/azureProvisionDialog.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/azurePublish/src/components/azureProvisionDialog.tsx b/extensions/azurePublish/src/components/azureProvisionDialog.tsx index 52ca515ff1..652d3862d6 100644 --- a/extensions/azurePublish/src/components/azureProvisionDialog.tsx +++ b/extensions/azurePublish/src/components/azureProvisionDialog.tsx @@ -346,7 +346,7 @@ export const AzureProvisionDialog: React.FC = () => { setPage(page); switch (page) { case PageTypes.AddResources: - telemetryClient.track('ProvisionAddResources'); + telemetryClient.track('ProvisionAddResourcesNavigate'); setTitle(DialogTitle.ADD_RESOURCES); break; case PageTypes.ChooseAction: