Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When saga error occurred, it should not turn into disconnect #2420

Closed
compulim opened this issue Sep 22, 2019 · 0 comments · Fixed by #2421
Closed

When saga error occurred, it should not turn into disconnect #2420

compulim opened this issue Sep 22, 2019 · 0 comments · Fixed by #2421
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented Sep 22, 2019

Version

master

Describe the bug

There are two problems:

  • When saga error, it disconnect Direct Line. Connectivity status turn from "sagaerror" to "disconnected"
  • But since there is a bug in "disconnected" reducer, an exception prevented "sagaerror" turn into "disconnected", but result in an exception

To Reproduce

  1. Open playground
  2. Click "Inject error"

Expected behavior

Check console log, there should be no exception other than the saga error. And the connectivity status should say, "Render error. Please check the console or contact the bot developer."

[Bug]

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Sep 22, 2019
@corinagum corinagum removed the Pending label Oct 11, 2019
@compulim compulim mentioned this issue Oct 29, 2019
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants