Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockBot URL's are broken and interlinking of samples are broken #2948

Closed
ashokduddukuri opened this issue Feb 26, 2020 · 6 comments · Fixed by #2968
Closed

MockBot URL's are broken and interlinking of samples are broken #2948

ashokduddukuri opened this issue Feb 26, 2020 · 6 comments · Fixed by #2968
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@ashokduddukuri
Copy link

ashokduddukuri commented Feb 26, 2020

References to Mockbot is broke in several samples.
Interlinking of samples are also broken.

This is one of the sample, the links are broken:
https://github.com/microsoft/BotFramework-WebChat/tree/master/samples/04.api/e.piping-to-redux

@ashokduddukuri ashokduddukuri added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. Pending customer-reported Required for internal Azure reporting. Do not delete. labels Feb 26, 2020
@corinagum
Copy link
Contributor

Yep - I found the same this morning. Investigating the cause.

@corinagum
Copy link
Contributor

@ashokduddukuri I'm not finding a repro of the interlinking samples being broken. The link you provided works for me. Could you send another interlinking sample that's not working?

@corinagum corinagum self-assigned this Feb 26, 2020
@tsuwandy tsuwandy added the customer-replied-to Required for internal reporting. Do not delete. label Feb 26, 2020
@corinagum
Copy link
Contributor

for the github pages samples, I am rerunning the CD as it failed this morning ~3am PST

@corinagum corinagum removed the Pending label Feb 26, 2020
@compulim
Copy link
Contributor

Thanks for reporting. Instead of re-run, I re-created a new CD and it should be fixed.

I am expecting it may fail again next week. Please keep the log by re-creating a new CD, so we can look at the log. Re-run will overwrite the log.

@ashokduddukuri
Copy link
Author

@corinagum

@corinagum
Copy link
Contributor

@ashokduddukuri, thanks for the extra info. I'll get a quick fix out today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants