Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLSpeech: Should not error out if bot did not send "speak" property, #2953

Closed
compulim opened this issue Feb 27, 2020 · 0 comments · Fixed by #3059
Closed

DLSpeech: Should not error out if bot did not send "speak" property, #2953

compulim opened this issue Feb 27, 2020 · 0 comments · Fixed by #3059
Assignees
@compulim
Labels
area-direct-line-speech bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented Feb 27, 2020 •
edited
Loading

Version

4.7.1

Describe the bug

When bot did not send an activity with speak property, DLSpeech channel will not send the WAV stream. Web Chat or Speech SDK should handle this scenario.

Steps to reproduce

  1. Connect to MockBot
  2. Say "tell me a story"
    • The returned activity does not have speak field set

Expected behavior

Web Chat will not synthesize the activity without "speak" property. But it should continue to function properly.

Additional context

Tagging @stevkan.

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. labels Feb 27, 2020
@corinagum corinagum added area-direct-line-speech and removed Bot Services Required for internal Azure reporting. Do not delete. Do not change color. Pending customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. labels Feb 27, 2020
@cwhitten cwhitten added the R9 label Mar 9, 2020
@compulim compulim mentioned this issue Mar 29, 2020
Merged
1 task
@compulim compulim mentioned this issue May 15, 2020
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
area-direct-line-speech bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Should not synthesis without speak property compulim/BotFramework-WebChat
3 participants
@cwhitten @compulim @corinagum