Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Web Chat to support DirectLine-Speech in Fairfax #3666

Closed
NickEricson opened this issue Jan 12, 2021 · 11 comments · Fixed by #3694
Closed

Upgrade Web Chat to support DirectLine-Speech in Fairfax #3666

NickEricson opened this issue Jan 12, 2021 · 11 comments · Fixed by #3694
Assignees
Labels
feature-request Azure report label p0 Must Fix. Release-blocker
Milestone

Comments

@NickEricson
Copy link
Member

Feature Request

Upgrade Web Chat to support DirectLine-Speech in Fairfax.

In Fairfax you need to connect to a different speech service (i.e. the channel endpoint is different). Web Chat should be updated to allow customers to specify the Fx domain so the correct endpoint is used.

cc @trrwilson for details.

[feature-request]

@NickEricson NickEricson added customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. feature-request Azure report label labels Jan 12, 2021
@corinagum
Copy link
Contributor

@NickEricson is this a customer request, or planned internally? (for tracking)

@NickEricson
Copy link
Member Author

This is planned work. Sorry if I got the Labels wrong.

@corinagum
Copy link
Contributor

No problem - they're automatic. Just want to make sure they're accurate. :) (Updating now)

@corinagum corinagum removed Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. labels Jan 13, 2021
@compulim
Copy link
Contributor

This is related to #3377.

I don't recall, but we might need to bump Speech SDK to get the sovereign cloud support, which is #3575.

@corinagum corinagum changed the title Upgrade Web Chat to support DirectLine-Speech in Fairfax Upgrade Web Chat to support DirectLine-Speech in Fairfax - related to #3377 Jan 13, 2021
@corinagum corinagum added this to the R12 milestone Jan 13, 2021
@NickEricson
Copy link
Member Author

@compulim I think this is related / duplicate of #3377. I believe the current sdk supports this via a named parameter and the next sdk will support it officially. @trrwilson can explain how to do this and timelines.

@trrwilson
Copy link
Member

trrwilson commented Jan 14, 2021

Thanks, @NickEricson !

Yes, I've recently published a PR to add friendly fromHost and fromEndpoint factories to BotFrameworkConfig in the JavaScript Speech SDK. You can find that here: microsoft/cognitive-services-speech-sdk-js#303

In the interim, it's fully possible to get all of this functionality (albeit it less elegantly) by setting values in the configuration property bag. E.g. if you'd like to use "my.host.convai.azure.us", you can:

let config: BotFrameworkConfig = sdk.BotFrameworkConfig.fromSubscription("mySubscriptionKey", "unusedRegion");
config.setProperty(sdk.PropertyId.SpeechServiceConnection_Host, "wss://my.host.convai.azure.us");
let connector: DialogServiceConnector = new DialogServiceConnector(config);

This will end up connecting to wss://my.host.convai.azure.us/api/v3, with the resource path after the host handled by the SDK.

If the resource path is different -- say, you have wss://my.host.azure.us/myPath/v9000 -- you do the same as above but use PropertyId.SpeechServiceConnection_Endpoint, which will not append the /api/v3 for you.

The PR (and having fromHost and fromEndpoint) will only be a simplification layer on top of these properties.

@corinagum corinagum added the p1 Painful if we don't fix, won't block releasing label Jan 14, 2021
@corinagum corinagum changed the title Upgrade Web Chat to support DirectLine-Speech in Fairfax - related to #3377 Upgrade Web Chat to support DirectLine-Speech in Fairfax Jan 14, 2021
@corinagum
Copy link
Contributor

corinagum commented Jan 14, 2021

Related to #3575
Need to verify that latest Speech SDK version is working for Fairfax, then confirm scheduling

@cwhitten cwhitten added p0 Must Fix. Release-blocker and removed p1 Painful if we don't fix, won't block releasing labels Jan 15, 2021
@trrwilson
Copy link
Member

trrwilson commented Jan 15, 2021

The aforementioned SDK PR, with fromHost and fromEndpoint methods added to the JavaScript BotFrameworkConfig object, is now merged and available for private builds (clone and npm install; npm run build if needed). It'll for sure be included in the 1.15 release, which we're targeting for next week.

Just to reiterate (I'll sound like a broken record, but it's worth it if it helps even a little!): this doesn't make anything that wasn't possible before possible now--it just makes it much more intuitive and convenient to use custom hosts and endpoints vs. needing to set the configuration property manually.

@NickEricson
Copy link
Member Author

@trrwilson Thank you for all the details on both how to connect to Fairfax using the current SDK and the updates for the 1.15 SDK.

@compulim
Copy link
Contributor

compulim commented Feb 1, 2021

I am bumping to 1.15.0 and it is working. Once the PR is merged, I will provide more information here (or in the PR description).

@compulim
Copy link
Contributor

compulim commented Feb 2, 2021

PR #3694 is under review now.

To enable sovereign clouds for Direct Line Speech. The fetchCredentials option passed to DirectLineSpeechSDK.createAdapters() call should return directLineSpeechHostname, instead of region. For example:

return { authorizationToken: '...', directLineSpeechHostname: 'virginia.convai.speech.azure.us' };

This change is outlined in the updated DIRECT_LINE_SPEECH.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Azure report label p0 Must Fix. Release-blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants