Fix pydantic and autodoc_pydantic version to <2.0.0 until support is added. #3290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
loadams
commented
Apr 18, 2023
loadams
commented
- pydantic is working on updating to a 2.0.0 that is not backwards compatible, we will need to add this, but since this will break our CI when it is released, this is a preventative step.
- autodoc_pydantic hasn't addressed how they will handle this, though it will be tracked in this issue. I assume they will update to 2.0.0 once they add support as well.
- Once pydantic 2.0.0 is released, fixes will be added in Update pydantic version and corresponding changes #3289.
loadams
changed the title
Closed
mrwyattii
approved these changes
Apr 18, 2023
pengwa
added a commit
to microsoft/onnxruntime
that referenced
this pull request
Jul 3, 2023
### Fix orttraining-ortmodule-distributed CI https://pypi.org/project/pydantic/#history released version 2.0 1st July, Deepspeed has known issue on newer version of it (deepspeedai/DeepSpeed#3280). So fix this by add similar check as DS did in deepspeedai/DeepSpeed#3290
|
@loadams You can now test the new autodoc_pydantic version supporting pydantic v2 via Any feedback is more than appreciated. The current autodoc_pydantic version |
|
@mansenfranzen Thanks for the update! We have another PR that we are working on for full v2 support: #3902 We were waiting on support from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.