Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIRV] strategy to merge/deprecate Vulkan specific feature attribute #2967

Closed
chaocNV opened this issue Jun 10, 2020 · 1 comment
Closed
Labels
spirv Work related to SPIR-V

Comments

@chaocNV
Copy link

chaocNV commented Jun 10, 2020

This was raised during discussion of a Vulkan specific feature attribute and I feel it warrants a separate issue.
We currently have and will have more Vulkan specific feature attributes for Vulkan features that native language constructs of HLSL does not support. Yet HLSL is also an evolving language and it will start to have native support for those features. So just as a general strategy discussion, what process(if any) should we have in place to monitor and merge/deprecate the Vulkan attributes and replace them with HLSL native when it becomes available?

@ehsannas ehsannas added the spirv Work related to SPIR-V label Jun 10, 2020
@sudonatalie
Copy link
Collaborator

I think it's fair to say that our new approach with inline SPIR-V solves this problem well enough by focusing on supporting a general purpose set attributes for any SPIR-V builtin functions, types, etc. Since we're no longer adding feature-specific attributes to DXC, this attribute churn and maintenance burden should be significantly lessened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spirv Work related to SPIR-V
Projects
None yet
Development

No branches or pull requests

3 participants