-
Notifications
You must be signed in to change notification settings - Fork 87
ShouldContinue & ShouldProcess attribute missing in the Cmdlets #171
Comments
These should be pretty simple fix, let me know if this is up for grabs. |
@DexterPOSH Thanks for the feedback. This is definitely up for grabs, and we'd be happy to have the contribution! |
@swernli awesome, I will get started on this then. |
@swernli started working on this, to begin with working on the Remove-* cmdlets from the module. |
@DexterPOSH Sorry I haven't responded yet, still catching up after vacation. I should be able to take a look soon! |
@DexterPOSH Finally got the chance to look over the changes, and the pattern looks good overall. I had a few minor comments that hopefully help. Thanks again for working on this contribution! |
@swernli Thanks for some very good feedback, I will resume the work and keep hitting you with more questions. |
Output of
$PSVersionTable
(from a powershell process):Output of
ipmo Docker; (module Docker).Version.ToString()
(from a powershell process):Steps to reproduce the issue:
What actually happened?:
Throws an error that no matching commands include a parameter named 'whatif' or 'confirm'
What did you expect to happen?:
As a best practice while developing cmdlets for PowerShell, it is recommended to Support ShouldProcess & ConfirmImpact cmdlet attributes.
Additional information:
Creating a Cmdlet that Modifies the System
The text was updated successfully, but these errors were encountered: