fix(version-tools): Correct handling of internal dev/prerelease versions #12734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit b5c8547 Author: Tyler Butler <[email protected]> Date: Fri Oct 28 11:54:51 2022 -0700 further relax version handling for prerelease/dev versions commit 39df103 Author: Tyler Butler <[email protected]> Date: Fri Oct 28 10:03:48 2022 -0700 build: Fix dependency ranges in published packages
commit 777d753 Merge: 0b8bdcc e900a58 Author: Tyler Butler <[email protected]> Date: Mon Oct 31 10:57:21 2022 -0700 Merge branch 'pipeline/fix-ranges' of https://github.com/microsoft/FluidFramework into pipeline/fix-ranges commit 0b8bdcc Merge: b5c8547 e08c825 Author: Tyler Butler <[email protected]> Date: Mon Oct 31 10:55:41 2022 -0700 Merge branch 'main' into pipeline/fix-ranges commit e900a58 Author: Tyler Butler <[email protected]> Date: Fri Oct 28 11:54:51 2022 -0700 fix(version-tools): Accept prerelease/dev versions for range bumps commit 84b8fa0 Merge: da04d41 562240e Author: Tyler Butler <[email protected]> Date: Fri Oct 28 15:39:57 2022 -0700 Merge branch 'main' into pipeline/fix-ranges commit da04d41 Author: Tyler Butler <[email protected]> Date: Fri Oct 28 15:36:39 2022 -0700 debugging commit 29791d0 Author: Tyler Butler <[email protected]> Date: Fri Oct 28 10:03:48 2022 -0700 build: Fix dependency ranges in published packages commit b5c8547 Author: Tyler Butler <[email protected]> Date: Fri Oct 28 11:54:51 2022 -0700 further relax version handling for prerelease/dev versions commit 39df103 Author: Tyler Butler <[email protected]> Date: Fri Oct 28 10:03:48 2022 -0700 build: Fix dependency ranges in published packages
This reverts commit c231859.
github-actions
bot
added
base: main
tylerbutler
commented
Oct 31, 2022
build-tools/packages/version-tools/src/internalVersionScheme.ts
Outdated
Show resolved
Hide resolved
tylerbutler
commented
Oct 31, 2022
build-tools/packages/version-tools/src/internalVersionScheme.ts
Outdated
Show resolved
Hide resolved
tylerbutler
commented
Oct 31, 2022
build-tools/packages/version-tools/src/internalVersionScheme.ts
Outdated
Show resolved
Hide resolved
Josmithr
approved these changes
Oct 31, 2022
alexvy86
pushed a commit
to alexvy86/FluidFramework
that referenced
this pull request
Nov 1, 2022
…ons (microsoft#12734) Some necessary changes were missing from microsoft#12721 that made it incomplete. This PR includes those changes, which should address that PR's goals of accommodating versions that have more than 4 prerelease sections and versions that use a non-internal prerelease identifier. Prior to this change, versions like 2.0.0-dev.2.1.0.104436, which is set in our CI pipeline, would cause a build failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some necessary changes were missing from #12721 that made it incomplete. This PR includes those changes, which should address that PR's goals of accommodating versions that have more than 4 prerelease sections and versions that use a non-internal prerelease identifier.
Prior to this change, versions like 2.0.0-dev.2.1.0.104436, which is set in our CI pipeline, would cause a build failure.