Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IContainerContext deprecations #16180

Merged
merged 6 commits into from
Jun 28, 2023

Conversation

ChumpChief
Copy link
Contributor

Deprecates disposed, dispose(), and id on IContainerContext.

Container creates the proxies, so it's appropriate for it to own the disposal as well (this consolidates the lifecycle ownership and authority to revoke access).

id was already noted as being for telemetry only, but we already log the docId (Container includes it in the logger it passes through) so this is redundant. The one place referencing it in the runtime doesn't actually access it.

We should be able to remove all of the above immediately in next after the change ports.

@ChumpChief ChumpChief requested review from a team as code owners June 28, 2023 22:01
@github-actions github-actions bot added area: loader Loader related issues area: runtime Runtime related issues public api change Changes to a public API labels Jun 28, 2023
@github-actions github-actions bot added the base: main PRs targeted against main branch label Jun 28, 2023
@ChumpChief ChumpChief requested a review from kian-thompson June 28, 2023 22:03
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: -95 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 451.05 KB 451.02 KB -39 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 241.71 KB 241.67 KB -43 Bytes
loader.js 154.17 KB 154.14 KB -31 Bytes
map.js 46.75 KB 46.75 KB +2 Bytes
matrix.js 146.68 KB 146.68 KB +2 Bytes
odspDriver.js 92.83 KB 92.84 KB +6 Bytes
odspPrefetchSnapshot.js 44.11 KB 44.11 KB +4 Bytes
sharedString.js 163.33 KB 163.33 KB +2 Bytes
sharedTree2.js 250.25 KB 250.25 KB No change
Total Size 1.71 MB 1.71 MB -95 Bytes

Baseline commit: 6592660

Generated by 🚫 dangerJS against 3a8e822

@@ -263,7 +263,6 @@ export interface IGarbageCollectorCreateParams {
readonly getLastSummaryTimestampMs: () => number | undefined;
readonly readAndParseBlob: ReadAndParseBlob;
readonly activeConnection: () => boolean;
readonly getContainerDiagnosticId: () => string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bizarre this even exists as it is never used.

@ChumpChief ChumpChief merged commit bf6a26c into microsoft:main Jun 28, 2023
@ChumpChief ChumpChief deleted the IContainerContextDeprecations branch June 28, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: loader Loader related issues area: runtime Runtime related issues base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants