-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IContainerContext deprecations #16180
Merged
ChumpChief
merged 6 commits into
microsoft:main
from
ChumpChief:IContainerContextDeprecations
Jun 28, 2023
Merged
IContainerContext deprecations #16180
ChumpChief
merged 6 commits into
microsoft:main
from
ChumpChief:IContainerContextDeprecations
Jun 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: loader
Loader related issues
area: runtime
Runtime related issues
public api change
Changes to a public API
labels
Jun 28, 2023
⯆ @fluid-example/bundle-size-tests: -95 Bytes
Baseline commit: 6592660 |
@@ -263,7 +263,6 @@ export interface IGarbageCollectorCreateParams { | |||
readonly getLastSummaryTimestampMs: () => number | undefined; | |||
readonly readAndParseBlob: ReadAndParseBlob; | |||
readonly activeConnection: () => boolean; | |||
readonly getContainerDiagnosticId: () => string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bizarre this even exists as it is never used.
anthony-murphy
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: loader
Loader related issues
area: runtime
Runtime related issues
base: main
PRs targeted against main branch
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates disposed, dispose(), and id on IContainerContext.
Container creates the proxies, so it's appropriate for it to own the disposal as well (this consolidates the lifecycle ownership and authority to revoke access).
id was already noted as being for telemetry only, but we already log the docId (Container includes it in the logger it passes through) so this is redundant. The one place referencing it in the runtime doesn't actually access it.
We should be able to remove all of the above immediately in
next
after the change ports.