Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move closeAndGetPendingLocalState to IContainerExperimental #16302

Conversation

anthony-murphy
Copy link
Contributor

This change deprecates the experimental method closeAndGetPendingLocalState on IContainer and moves it to IContainerExperimental.
IContainerExperimental is an interface that is easily casted to, which enables partners to access experimental features for testing and evaluation.
Moving the experimental method off IContainer will reduce exposure and churn on that production interface as we iterate on and finalize our experimental features.
Experimental features should not be used in production environments.

@anthony-murphy anthony-murphy requested review from msfluid-bot and a team as code owners July 10, 2023 21:25
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree area: loader Loader related issues area: tests Tests to add, test infrastructure improvements, etc public api change Changes to a public API labels Jul 10, 2023
@github-actions github-actions bot added the base: main PRs targeted against main branch label Jul 10, 2023
Copy link
Contributor

@dannimad dannimad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect this change to affect blobIsAttached test at the very least cause it calls getPendingLocalState but I didn't dig much into it. Seems like everything passes.

@anthony-murphy
Copy link
Contributor Author

I would expect this change to affect blobIsAttached test at the very least cause it calls getPendingLocalState but I didn't dig much into it. Seems like everything passes.

this is only the Container, not the ContainerRuntime

@anthony-murphy anthony-murphy merged commit 93151af into microsoft:main Jul 10, 2023
@anthony-murphy anthony-murphy deleted the pendingstate-on-experimental-interface branch July 10, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures area: loader Loader related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants