-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PropertyDDS packages which are not depended on by PropertyDDS #22326
Conversation
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 84b5c4e |
Obligatory question: were you able to check with partners to see if this change would impact them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for docs team.
Last Wednesday in our sync they were asked if they had any reason not to do this (and they didn't), and I'm giving them a week find any reasons they could not think of at the time. Should I receive no opposition by tomorrow by tomorrow, I think it makes sense to go ahead with this removal. None of these packages have been actively maintained, and I confirmed the two main customers have their own forks/alternatives to property inspector table which the independently maintain and would not be impacted by this one being removed. As for the other packages, no on expressed any opinions yet, which means no reason to keep them. We can of course restore these packages is needed, though at that point I'd suggest who ever needed them actively maintain the package, and prefer they be restored to a different repository unless there is a good reason they need to be in this one. |
Update changeset Co-authored-by: Tyler Butler <[email protected]>
Autodesk has requested a 2-3 day timeline extension to finish reviewing their use of these packages. moving the expected date for proceeding with this back to ~ Friday. Edit: Got the go-ahead from Autodesk. Will merge. |
…to trimPropertyDDS
…to trimPropertyDDS
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
## Description Removes property-query-service in LTS and update the lock file. This package was removed from main in #20052. Also removed several other PropertyDDS auxiliary packages which were removed from main in #22326 and #20119: - @fluid-experimental/property-query - @fluid-experimental/property-binder - @fluid-experimental/property-proxy - @fluid-experimental/property-inspector-table - @fluid-example/property-inspector - @fluid-example/schemas - @fluid-experimental/partial-checkout This resolves a CVE for `[email protected]` that was pulled in as a transitive dependency of this PropertyDDS package. [AB#25462](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/25462) --------- Co-authored-by: Abram Sanderson <[email protected]>
Description
Deletes some packages from experimental/PropertyDDS.
The DDS and its dependencies are kept, but the rest of its packages are not.
Delete the following published experimental packages:
Delete the following private packages:
Changes made by deleting the packages, then running:
and manually adding a changeset.
Breaking Changes
These packages will no longer be published:
Reviewer Guidance
The review process is outlined on this wiki page.