-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further MergeTree Client Legacy Deprecations #22629
Further MergeTree Client Legacy Deprecations #22629
Conversation
4d29340
to
509baa6
Compare
509baa6
to
4be63b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changeset looks great - just wording tweaks and minor formatting. Your level of detail was great.
Typically I would suggest trying to link to the docs for the types, but in this case that seems unnecessary since these types aren't likely to be used right now anyway. Maybe links to docs for deprecations in general is unnecessary. Links to docs make way more sense with new or changed APIs. @microsoft/fluid-cr-docs Curious what others think. We can take that discussion to another forum though.
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 7febffe |
Co-authored-by: jzaffiro <[email protected]>
Co-authored-by: Tyler Butler <[email protected]>
Co-authored-by: jzaffiro <[email protected]>
Co-authored-by: jzaffiro <[email protected]>
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
In an effort the reduce exposure of the Client class in the merge-tree package this change additionally deprecates a number of types which either directly or indirectly expose the merge-tree Client class.
Most of these types are not meant to be used directly, and direct use is not supported:
Some of the deprecations are for class constructors and in those cases we plan to replace the class with an interface which has an equivalent API. Direct instantiation of these classes is not currently supported or necessary for any supported scenario, so the change to an interface should not impact usage: