-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client-presence): use common event support #23196
feat(client-presence): use common event support #23196
Conversation
- Use event types from core-interfaces and implementation from client-utils. - Add `off` event deregistration support. - Rename types following the updates that had been made to "core-interfaces" events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Coverage Summary
↑ packages.framework.presence.src:
Line Coverage Change: 0.12% Branch Coverage Change: -0.09%
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 88.57% | 88.48% | ↓ -0.09% |
Line Coverage | 73.96% | 74.08% | ↑ 0.12% |
Baseline commit: fa4a02e
Baseline build: 309873
Happy Coding!!
Code coverage comparison check passed!!
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: fa4a02e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the changeset. Looks good other than the comment below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API changes are good
closing to nudge stuck "licesnse/cla" check |
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
off
event deregistration support.