Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client-presence): use common event support #23196

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

jason-ha
Copy link
Contributor

  • Use event types from core-interfaces and implementation from client-utils.
  • Add off event deregistration support.
  • Rename types following the updates that had been made to "core-interfaces" events.

- Use event types from core-interfaces and implementation from client-utils.
- Add `off` event deregistration support.
- Rename types following the updates that had been made to "core-interfaces" events.
@jason-ha jason-ha requested a review from a team as a code owner November 23, 2024 01:13
@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct changeset-present dependencies Pull requests that update a dependency file public api change Changes to a public API base: main PRs targeted against main branch labels Nov 23, 2024
Copy link
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

↑ packages.framework.presence.src:
Line Coverage Change: 0.12%    Branch Coverage Change: -0.09%
Metric NameBaseline coveragePR coverageCoverage Diff
Branch Coverage 88.57% 88.48% ↓ -0.09%
Line Coverage 73.96% 74.08% ↑ 0.12%

Baseline commit: fa4a02e
Baseline build: 309873
Happy Coding!!

Code coverage comparison check passed!!

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Nov 23, 2024

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 467.08 KB 467.11 KB +35 Bytes
azureClient.js 563.85 KB 563.9 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 263.27 KB 263.29 KB +14 Bytes
fluidFramework.js 428.71 KB 428.73 KB +14 Bytes
loader.js 134.18 KB 134.19 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 150.15 KB 150.16 KB +7 Bytes
odspClient.js 530.45 KB 530.5 KB +49 Bytes
odspDriver.js 98.65 KB 98.67 KB +21 Bytes
odspPrefetchSnapshot.js 43.04 KB 43.05 KB +14 Bytes
sharedString.js 166.23 KB 166.24 KB +7 Bytes
sharedTree.js 419.17 KB 419.18 KB +7 Bytes
Total Size 3.38 MB 3.38 MB +245 Bytes

Baseline commit: fa4a02e

Generated by 🚫 dangerJS against 83e6038

Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changeset. Looks good other than the comment below.

Copy link
Contributor

@noencke noencke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API changes are good

@jason-ha
Copy link
Contributor Author

closing to nudge stuck "licesnse/cla" check

@jason-ha jason-ha closed this Nov 26, 2024
@jason-ha jason-ha reopened this Nov 26, 2024
@jason-ha jason-ha enabled auto-merge (squash) November 26, 2024 17:53
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170006 links
    1595 destination URLs
    1825 URLs ignored
       0 warnings
       0 errors


@jason-ha jason-ha merged commit f7be965 into microsoft:main Nov 26, 2024
40 checks passed
@jason-ha jason-ha deleted the presence/use-common-events-support branch December 19, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch changeset-present dependencies Pull requests that update a dependency file public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants