-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging in DeltaScheduler #8909
Comments
I can't find obvious bug in logic, but data does not match my intuition about how it should work. Do we test that DeltaScheduler does not pause ops if there not many of them / they are processed fast? Can we convert existing tests to use mock timer? Please take a closer look, it would be said if our latencies are affected not because of network / service, but because of silly bugs |
Please note that #8912 tracks more generic problem of tracking who pauses inbound queue and for how long |
Closing as fixed by above mentioned PR. |
Forking from #8908 concrete work:
I see 531K "InboundOpsProcessingTime" events in one day.
So yes, DeltaScheduler seems like is being hit a lot.
One thing that I do not like is that we issue event only if we hit 2K idle states.
It feels like once we set a timer in batchEnd(), we have to report an event that it happened, and ideally
3.Once done (reached idle), how many ops actually were processed (will be different from # 2, as ops are coming in).
BTW, this.isScheduling seems can be removed. It's always true when we process ops, and always false when we stop processing ops. Given that we always alternate between these states, there is no reason to check the value - we know what the value is
The text was updated successfully, but these errors were encountered: