Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup code loader types from @fluidframework/core-interfaces #9034

Closed
Tracked by #8193
ssimic2 opened this issue Feb 7, 2022 · 1 comment
Closed
Tracked by #8193

Cleanup code loader types from @fluidframework/core-interfaces #9034

ssimic2 opened this issue Feb 7, 2022 · 1 comment
Assignees
@sonalivdeshpande
Labels
api deprecation Changes to a deprecated API
Milestone
March 2022

Comments

@ssimic2
Copy link

ssimic2 commented Feb 7, 2022 •
edited by sonalivdeshpande
Loading

After ensuring we have transitioned all partner repos to ingest code loader types @fluidframework/container-definitions, let's clean up deprecated types around @fluidframework/core-interfaces.

  1. Delete fluidPackage.ts from @fluidframework/core-interface.
  2. Remove remaining deprecated code loader types from @fluidframework/core-interface.

Given that reverting code around definitions would be multi-step process, let's take care of this item only when we are sure all is well in partner repos.
@ssimic2 ssimic2 added the api deprecation Changes to a deprecated API label Feb 7, 2022
@ssimic2 ssimic2 added this to the February 2022 milestone Feb 7, 2022
@ssimic2 ssimic2 mentioned this issue Feb 7, 2022
Closed
7 tasks
@ssimic2 ssimic2 changed the title Cleanup code loader types from @fluidframework/core-interfaces Cleanup code loader types from @fluidframework/core-interfaces and remove ICodeLoader Feb 7, 2022
@ssimic2 ssimic2 mentioned this issue Feb 7, 2022
Closed
@sonalivdeshpande
Copy link
Contributor

sonalivdeshpande commented Mar 10, 2022 •
edited
Loading

The changes are expected to go in release 0.59

@sonalivdeshpande sonalivdeshpande changed the title Cleanup code loader types from @fluidframework/core-interfaces and remove ICodeLoader Cleanup code loader types from @fluidframework/core-interfaces Mar 29, 2022
@sonalivdeshpande sonalivdeshpande mentioned this issue Mar 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sonalivdeshpande sonalivdeshpande

Labels
api deprecation Changes to a deprecated API
Projects
None yet
Milestone
March 2022
Development

No branches or pull requests
3 participants
@anthony-murphy @ssimic2 @sonalivdeshpande