Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ReconnectMode to container-definitions #9166

Closed
3 tasks
scottn12 opened this issue Feb 17, 2022 · 0 comments
Closed
3 tasks

Move ReconnectMode to container-definitions #9166

scottn12 opened this issue Feb 17, 2022 · 0 comments
Labels
api deprecation Changes to a deprecated API triage

Comments

@scottn12
Copy link
Contributor

scottn12 commented Feb 17, 2022

As part of the plan to use ReconnectMode enum as an argument in the reworked setAutoReconnect() (see #9167), ReconnectMode will be moved to container-definitions. The new ReconnectMode is planned to be defined as:

export enum ReconnectMode {
    Never = "Never",
    Disabled = "Disabled",
    Enabled = "Enabled",
    Custom = "Custom"
}

The Custom enum member will be introduced to enable the developer to use their own callback function to determine when the container should and should not be reconnected (see #9167 for more details).

Tasks:

  • Deprecate ReconnectMode from container-loader and re-create in container-definitions
  • Replace all usages of ReconnectMode with the new version
  • Remove deprecated ReconnectMode after two releases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api deprecation Changes to a deprecated API triage
Projects
None yet
1 participant