Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to manage Loop settings #2004

Open
ykuijs opened this issue Jun 10, 2022 · 6 comments
Open

Add possibility to manage Loop settings #2004

ykuijs opened this issue Jun 10, 2022 · 6 comments
Labels

Comments

@ykuijs
Copy link
Member

ykuijs commented Jun 10, 2022

Details of the scenario you tried and the problem that is occurring

Recently, the opportunity to manage Loop settings via PowerShell has been added. These settings need to get added to M365DSC as well.

Announcement (look for "New Admin PowerShell control for Loop components"): https://techcommunity.microsoft.com/t5/microsoft-sharepoint-blog/sharepoint-roadmap-pitstop-may-2022/ba-p/3468499
Manage Loop components in SharePoint: https://docs.microsoft.com/en-us/sharepoint/manage-loop-components

Suggested solution to the issue

A new resource might be a good idea, but since the settings are added to the Get-SPOTenant cmdlet, maybe the SPOTenantSettings resource is also a good idea. In this last case: Maybe we have to connect with the PnP team to see if they plan to add these settings to Get-PnPTenant as well.

@ykuijs ykuijs added the Enhancement New feature or request label Jun 10, 2022
@NikCharlebois
Copy link
Collaborator

This is currently not supported as part of PnP (Get-PnpTenant). Let's revisit once this property is added.
pnp/powershell#2189

@andikrueger
Copy link
Collaborator

andikrueger commented Apr 5, 2023

This is already part of the PnP PowerShell since Sept. 2022. We should be good to go.

Update: there is a difference between the PnP PowerShell and the SPO PowerShell

Settingname PnP PowerShell SPO PowerShell
isLoopEnabled x -
OneDriveLoopSharingCapability - x
OneDriveLoopDefaultSharingLinkScope - x
OneDriveLoopDefaultSharingLinkRole - x
CoreLoopSharingCapability - x
CoreLoopDefaultSharingLinkScope - x
CoreLoopDefaultSharingLinkRole - x

@andikrueger
Copy link
Collaborator

Created a new request: pnp/powershell#2975

@NikCharlebois
Copy link
Collaborator

Looks like this may be a catch 21. We made a decision a few years back to adopt PnP.PowerShell over SPO PowerShell. On top of this, the latest PnP.PowerShell module v2.1.* only works for PowerShell 7 and we need to ensure support for both 5 and 7.

@andikrueger
Copy link
Collaborator

This is something I feared... Basically, we are not able to introduce these changes, as this would break our support for PS 5.1 and we would have to wait for the October release. The other issue at hand is that DSC works best on PS 5.1....

Is there any chance to provide a custom M365DSCPnPPower(S)Hell Version or are these settings somehow exposed by MSGraph?

@NikCharlebois
Copy link
Collaborator

The recommendation here would be for us to wait for these SPO Admin APIs to be available on Graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants