Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization of Tags is not working correctly #1922

Closed
MaggieKimani1 opened this issue Nov 13, 2024 · 0 comments · Fixed by #1939
Closed

Serialization of Tags is not working correctly #1922

MaggieKimani1 opened this issue Nov 13, 2024 · 0 comments · Fixed by #1939
Assignees
@MaggieKimani1
Labels
priority:p0 Blocking issue/ loss of critical functions. An ICM may be filed to communicate urgency. SLA<=48hrs
Milestone
v2 - Preview3

Comments

@MaggieKimani1
Copy link
Contributor

MaggieKimani1 commented Nov 13, 2024 •
edited
Loading

Describe the bug
In V2.0, tags aren't properly serialized which leads to loss of information

OpenApi File To Reproduce
A document with tags at the root level defined as below:

tags:
  - name: City.City
    x-ms-docs-toc-type: page
  - name: CountryOrRegion.CountryOrRegion
    x-ms-docs-toc-type: page
  - name: Me.Person
    x-ms-docs-toc-type: page
  - name: People.Person
    x-ms-docs-toc-type: page

Emits:

tags:
  - City.City
  - CountryOrRegion.CountryOrRegion
  - Me.Person
  - People.Person

Expected behavior
All properties for root-level tags should be written out properly
@MaggieKimani1 MaggieKimani1 self-assigned this Nov 13, 2024
@MaggieKimani1 MaggieKimani1 added type:bug A broken experience priority:p0 Blocking issue/ loss of critical functions. An ICM may be filed to communicate urgency. SLA<=48hrs and removed type:bug A broken experience labels Nov 13, 2024
@MaggieKimani1 MaggieKimani1 mentioned this issue Nov 18, 2024
Merged
@darrelmiller darrelmiller added this to the NET:2.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaggieKimani1 MaggieKimani1

Labels
priority:p0 Blocking issue/ loss of critical functions. An ICM may be filed to communicate urgency. SLA<=48hrs
Projects
None yet
Milestone
v2 - Preview3
Development

Successfully merging a pull request may close this issue.

Fix tags serialization bug microsoft/OpenAPI.NET
2 participants
@darrelmiller @MaggieKimani1