Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always on Top doesn't have an icon on TaskManager #15280

Closed
1 task
jaimecbernardo opened this issue Jan 6, 2022 · 22 comments
Closed
1 task

Always on Top doesn't have an icon on TaskManager #15280

jaimecbernardo opened this issue Jan 6, 2022 · 22 comments
Assignees
Labels
Issue-Bug Something isn't working Priority-3 Bug that is low priority Product-Always On Top Refers to the idea of a Always on Top Powertoy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@jaimecbernardo
Copy link
Collaborator

jaimecbernardo commented Jan 6, 2022

Microsoft PowerToys version

0.53

Running as admin

  • Yes

Area(s) with issue?

AlwaysOnTop

Steps to reproduce

With Always on Top enabled, check the "PowerToys.AlwaysOnTop.exe" icon on Task Manager.

✔️ Expected Behavior

It should have an icon.

❌ Actual Behavior

It has no icon.

Other Software

No response

@jaimecbernardo jaimecbernardo added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jan 6, 2022
@Aaron-Junker Aaron-Junker added the Product-Always On Top Refers to the idea of a Always on Top Powertoy label Jan 6, 2022
@crutkas crutkas added Priority-3 Bug that is low priority Help Wanted We encourage anyone to jump in on these and submit a PR. Good first issue Good for newcomers. and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jan 7, 2022
@wtbrins
Copy link

wtbrins commented Jan 23, 2022

Hello, I am new to open source and would like to help. Could I be assigned this issue?

@franky920920
Copy link
Contributor

franky920920 commented Jan 24, 2022

@wtbrins Sure you can! Let us know if you need anything from us. See https://github.com/microsoft/PowerToys/blob/main/doc/devdocs/readme.md that might help. :D

cc: @crutkas

@timstoldt
Copy link

Is this still actively being worked on? If not I would love to give it a shot!

@wtbrins
Copy link

wtbrins commented Mar 23, 2022

im still working on this just have not made a ton of progress because of school

@Jay-o-Way
Copy link
Collaborator

@timstoldt @wtbrins how's progress going? :)

@crutkas
Copy link
Member

crutkas commented Jul 22, 2022

suggestion here for AOT is to just use the existing PowerToys icon

@marmales
Copy link

marmales commented Aug 6, 2022

Can I take this issue as there is no response from @wtbrins and @timstoldt?

@crutkas
Copy link
Member

crutkas commented Aug 6, 2022

Yup

@hussain123
Copy link

Can this be assigned to me as there is no response from the assignee?

@crutkas
Copy link
Member

crutkas commented Sep 9, 2022

@hussain123 run with it

@shaswat94
Copy link

@crutkas, Taking this issue up.

@shaswat94
Copy link

Not able to test my fix, any leads? @crutkas

@crutkas
Copy link
Member

crutkas commented Dec 13, 2022

I need more information on what you tried. I'd suggest building the entire solution and setting runner as the start up project. Debug from there.

@shaswat94
Copy link

shaswat94 commented Dec 14, 2022

The .ico file is missing for AlwaysOnTop. Need to figure out a way to add the main app icon for AlwaysOnTop.

@shaswat94
Copy link

Tried adding .ico file to the .vcxproj. The icon is now being displayed on the output application directory but still doesn't show up in the TaskManger. Any help?

@crutkas
Copy link
Member

crutkas commented Dec 15, 2022

Possible to get a link to your fork?

@shaswat94
Copy link

Possible to get a link to your fork?
https://github.com/shaswat94/PowerToys/tree/shaswat_15280 - Link to my branch with updated code.

@crutkas
Copy link
Member

crutkas commented Dec 15, 2022

Did you happen to push your code to your branch? There is no diff

@shaswat94
Copy link

Did you happen to push your code to your branch? There is no diff

Apologies for the confusion. Please refer to: https://github.com/shaswat94/PowerToys/tree/main_shaswat_always_on_top_22687
for changes

@htcfreek
Copy link
Collaborator

htcfreek commented Jan 7, 2024

@ckirby19
Feel free to open a PR. Your contribution is welcome. Thank you for your work on this.

@ckirby19
Copy link
Contributor

Added a PR for this now

@htcfreek htcfreek added the Status-In progress This issue or work-item is under development label Jan 14, 2024
@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Jan 17, 2024
@Jay-o-Way Jay-o-Way removed Help Wanted We encourage anyone to jump in on these and submit a PR. Good first issue Good for newcomers. labels Jan 23, 2024
@jaimecbernardo
Copy link
Collaborator Author

Hi, this has been worked on for the 0.78 development cycle. 😄
Please update PowerToys to the latest: https://github.com/microsoft/PowerToys/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Priority-3 Bug that is low priority Product-Always On Top Refers to the idea of a Always on Top Powertoy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests