Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Walker should have text focus on activation #1800

Closed
tchara opened this issue Mar 31, 2020 · 11 comments
Closed

Windows Walker should have text focus on activation #1800

tchara opened this issue Mar 31, 2020 · 11 comments
Assignees
Labels
Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@tchara
Copy link

tchara commented Mar 31, 2020

Summary of the new feature/enhancement

When activating Windows Walker through Ctrl+Win, the input field should have focus so that one can start typing immediately. Currently, one needs to click it with the mouse or hit Tab once.

Proposed technical implementation details (optional)

Set the focus() property on activation.

@enricogior
Copy link
Contributor

Hi @tchara
I've tried on a couple of different PCs and on both Window Walker has the focus active and you can type right away.
Can you verify if the problem you are seeing is persistent?
Thanks.

@tchara
Copy link
Author

tchara commented Mar 31, 2020

It happens when I have the focus in Outlook (365 v20.03), but I cannot pinpoint a reproducible behaviour.

Sometimes, it consistently refuses to set the focus in Window Walker when I am in the e-mail list. Other times it just works fine.

The same is oddly the case with editing calendar items. Sometimes the focus remains outside Windows Walker, sometimes it does not.

Based on this behaviour, I presume Outlook somehow snatches/hijacks the focus?

@Scott-Cullen
Copy link

On my machine the text focus only works on the first try.

If you find an application, switch to it then activate the feature again the text box will not automatically have focus until you press tab/select with the mouse.

@enricogior enricogior added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Apr 1, 2020
@crutkas
Copy link
Member

crutkas commented Apr 1, 2020

i think it is slightly inconsistent. I've seen this a bit too. @betsegaw any ideas?

@betsegaw
Copy link
Contributor

betsegaw commented Apr 1, 2020

I haven't run into this yet. Back in the day, there used to be some issues with focus, specifically on launch (after a reboot). I will assign it to myself and take a look.

@betsegaw
Copy link
Contributor

betsegaw commented Apr 1, 2020

Oh wait.. already assigned 👍

@betsegaw
Copy link
Contributor

betsegaw commented Apr 2, 2020

Okay.. so I got one repro and maybe a fix for this will also fix the other ones.

  1. CTRL + WIN
  2. a
  3. Using your mouse, click on the app to switch to
  4. CTRL + Win

Result : Focus is nowhere to be seen...

@tchara, did you use the mouse to select the result at any point?

@betsegaw
Copy link
Contributor

betsegaw commented Apr 2, 2020

The change I applied will hopefully fix the more general case as well. Please do ping back if it doesn't.

@tchara
Copy link
Author

tchara commented Apr 2, 2020

Okay.. so I got one repro and maybe a fix for this will also fix the other ones.

  1. CTRL + WIN
  2. a
  3. Using your mouse, click on the app to switch to
  4. CTRL + Win

Result : Focus is nowhere to be seen...

@tchara, did you use the mouse to select the result at any point?

Now that you mention it, yes. If I am near the item with the mouse I just click it rather than using the keyboard.

@runxel
Copy link

runxel commented Apr 2, 2020

For me it consistently doesn't work.

@enricogior
Copy link
Contributor

Hi @runxel
we have a fix ready, it will be included in the 0.16.1 release.

@crutkas crutkas added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Apr 14, 2020
@crutkas crutkas closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

6 participants