Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Launcher] Fix highlighting of selection on context buttons vs search result #2559

Closed
jyuwono opened this issue Apr 30, 2020 · 3 comments
Closed

[Launcher] Fix highlighting of selection on context buttons vs search result #2559

jyuwono opened this issue Apr 30, 2020 · 3 comments
Labels
Priority-1 Bug that is high priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Stability Release

Comments

@jyuwono
Copy link
Contributor

jyuwono commented Apr 30, 2020

Per discussion in this PR, we need a clear indication of the highlighted selection when using Tab to navigate.
@jyuwono jyuwono added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Apr 30, 2020
@jyuwono jyuwono mentioned this issue Apr 30, 2020
Merged
2 tasks
@niels9001
Copy link
Contributor

@jyuwono @ryanbodrug-microsoft I can take a look at this, probably a focus visual state that could be missing?

@jyuwono
Copy link
Contributor Author

jyuwono commented May 4, 2020

@niels9001 awesome, thanks a lot! Yes. I think the main concern here is when someone is pressing Tab to go through the search result and the buttons, it's not clear which focus the Tab is currently at. If we could add a highlight (or another visual indication) on what's currently in focus, that would be very helpful. Really appreciate your help, @niels9001 !

@jyuwono jyuwono added this to the v1.0 Release milestone May 4, 2020
@jyuwono jyuwono modified the milestones: v1.0 Release, Build 2020 May 11, 2020
@jyuwono jyuwono modified the milestones: Build 2020, v1.0 Release May 14, 2020
@dsrivastavv dsrivastavv mentioned this issue May 28, 2020
Merged
5 tasks
@jyuwono jyuwono added the Priority-1 Bug that is high priority label Jun 1, 2020
@jyuwono jyuwono mentioned this issue Jun 12, 2020
Closed
@crutkas crutkas added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jun 28, 2020
@crutkas
Copy link
Member

crutkas commented Jun 30, 2020

Fixed in 0.19.0, please visit https://github.com/microsoft/PowerToys/releases/ for the latest release

@crutkas crutkas closed this as completed Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority-1 Bug that is high priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Stability Release
Development

No branches or pull requests
3 participants
@crutkas @jyuwono @niels9001