Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerToys Peek - close with ESC #32814

Closed
georgelogosol opened this issue May 10, 2024 · 8 comments
Closed

PowerToys Peek - close with ESC #32814

georgelogosol opened this issue May 10, 2024 · 8 comments
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Issue-Bug Something isn't working Priority-2 Bug that is medium priority Product-Peek Refers to Peek Powertoys Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Status-Reproducible This issue was reproduced by a maintainer

Comments

@georgelogosol
Copy link

georgelogosol commented May 10, 2024

crutkas: I can get this to happen only if i'm in a monaco preview pane (aka webview2). I think that eats the esc. Soon as i click the titlebar, esc works again.

Description of the new feature / enhancement

Would be nice to have Peek applet to close with ESC (when not set to close on losing focus).

Scenario when this would be used?

In keyboard-heavy environments: File Explorer with several files, one needs to view quickly. Select the file with up/down, to open Peek, do something else, return to Peek with Alt-Tab. Hitting most of the time requires two hands.

Supporting information

No response

@georgelogosol georgelogosol added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label May 10, 2024
Copy link

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@crutkas
Copy link
Member

crutkas commented May 10, 2024

Esc works to close Peek if it is in focus. I'm testing with 0.80.1

Can you provide a full scenario cause maybe i'm missing the nuance of your ask. /needinfo

What i'm doing is

  1. selecting a file in file explorer. In this case, a json file
  2. Hitting Control-Space to invoke Peek
  3. Alt-Tab to Edge
  4. Alt-Tab back to Peek
  5. Hit ESC key

Peek dismisses.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels May 10, 2024
@georgelogosol
Copy link
Author

georgelogosol commented May 10, 2024 via email

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels May 10, 2024
@ethanfangg
Copy link
Contributor

What do your Peek settings look like?

@ethanfangg ethanfangg added Issue-Bug Something isn't working Product-Peek Refers to Peek Powertoys Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels May 10, 2024
@georgelogosol
Copy link
Author

georgelogosol commented May 10, 2024 via email

@jiez1812
Copy link

jiez1812 commented Jun 7, 2024

Hi, I encountered the same issue where Peek doesn't close when pressing esc. Strangely, I managed to resolve it by enabling and disabling auto close. Now, it can be closed by pressing esc.

@crutkas crutkas added Status-Reproducible This issue was reproduced by a maintainer Priority-2 Bug that is medium priority and removed Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. labels Nov 1, 2024
@crutkas crutkas added this to the PowerToys 0.87 milestone Nov 1, 2024
@crutkas crutkas added the Help Wanted We encourage anyone to jump in on these and submit a PR. label Nov 1, 2024
@github-project-automation github-project-automation bot moved this to ⚠️Needs Walkthrough in 3. Help Wanted Nov 1, 2024
@ethanfangg
Copy link
Contributor

/dup #26137

Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot removed this from the PowerToys 0.87 milestone Nov 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Nov 1, 2024
@github-project-automation github-project-automation bot moved this from ⚠️Needs Walkthrough to ✅Done in 3. Help Wanted Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Issue-Bug Something isn't working Priority-2 Bug that is medium priority Product-Peek Refers to Peek Powertoys Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Status-Reproducible This issue was reproduced by a maintainer
Projects
Status: ✅Done
Development

No branches or pull requests

4 participants