Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT Run] Some packaged apps have no icon #3541

Closed
htcfreek opened this issue May 22, 2020 · 7 comments
Closed

[PT Run] Some packaged apps have no icon #3541

htcfreek opened this issue May 22, 2020 · 7 comments
Assignees
@alekhyareddy28
Labels
Priority-1 Bug that is high priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
InVEST-2007

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented May 22, 2020 •
edited
Loading 

Windows: 10.0.18363
PT: 0.18.1
Module: PT Runnet

The following packaged apps have only the default app icon:

  • Calculator
  • Snip & Sketch
  • Windows-Security
@jyuwono jyuwono added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label May 28, 2020
@crutkas
Copy link
Member

crutkas commented Jun 2, 2020

is your system localized?

@htcfreek
Copy link
Collaborator Author

htcfreek commented Jun 2, 2020 •
edited
Loading

Yes: de-de (German)

@crutkas
Copy link
Member

crutkas commented Jun 2, 2020

@alekhyareddy28 can repro this, i can't

@crutkas crutkas added this to the v1.0 Release milestone Jun 2, 2020
@crutkas crutkas added the Priority-1 Bug that is high priority label Jun 2, 2020
@crutkas
Copy link
Member

crutkas commented Jun 2, 2020

app still launch, right?

@alekhyareddy28 alekhyareddy28 mentioned this issue Jun 3, 2020
Merged
5 tasks
@alekhyareddy28
Copy link
Contributor

It wasn't related to localization. Rather, not all the .png paths were being checked. Only the one's with scale were being checked such as Square44x44Logo.scale-xxx.png, however, not all apps have it in this format. Some of them have the theme along with it such as Calculator which has contrast-white or contract-black along with it such as CalculatorAppList.contrast-xxxx_scale-xxx.png. Whereas, very few apps don't have scale associated with them, rather they have targetSize, so added a condition to check that as well when we are unable to retrieve the logo from scale and theme.

@htcfreek
Copy link
Collaborator Author

htcfreek commented Jun 3, 2020

app still launch, right?

Yes.

@crutkas crutkas added the Status-In progress This issue or work-item is under development label Jun 3, 2020
@alekhyareddy28 alekhyareddy28 self-assigned this Jun 5, 2020
@alekhyareddy28 alekhyareddy28 added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Jun 5, 2020
@crutkas
Copy link
Member

crutkas commented Jun 30, 2020

Fixed in 0.19.0, please visit https://github.com/microsoft/PowerToys/releases/ for the latest release

@crutkas crutkas closed this as completed Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alekhyareddy28 alekhyareddy28

Labels
Priority-1 Bug that is high priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
InVEST-2007
Development

No branches or pull requests
5 participants
@crutkas @jyuwono @alekhyareddy28 @ryanbodrug-microsoft @htcfreek