Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Peek][PreviewPane] Support for .resx and .resw files #36295

Closed
davidegiacometti opened this issue Dec 10, 2024 · 5 comments
Closed

[Peek][PreviewPane] Support for .resx and .resw files #36295

davidegiacometti opened this issue Dec 10, 2024 · 5 comments
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-File Explorer Power Toys that touch explorer like Preview Pane Product-Peek Refers to Peek Powertoys Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete.
Milestone
PowerToys 0.88

Comments

@davidegiacometti
Copy link
Collaborator

davidegiacometti commented Dec 10, 2024 •
edited
Loading

Allow users to quickly preview resource files (.resx and .resw) in Peek and Explorer PreviewPane. Both are xml files and can be easy previewed in Monaco editor.
@davidegiacometti davidegiacometti added Idea-Enhancement New feature or request on an existing product Product-File Explorer Power Toys that touch explorer like Preview Pane Product-Peek Refers to Peek Powertoys labels Dec 10, 2024
@davidegiacometti davidegiacometti changed the title [Peek][PreviewPane] Support for .resx and .resw [Peek][PreviewPane] Support for .resx and .resw files Dec 10, 2024
@htcfreek
Copy link
Collaborator

As plain text, xml code or as resource (string) table?

/needinfo

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Dec 10, 2024
@crutkas
Copy link
Member

crutkas commented Dec 10, 2024

IMO good idea. We already do the formatting in the reg previewer

@davidegiacometti
Copy link
Collaborator Author

davidegiacometti commented Dec 11, 2024 •
edited
Loading

As xml in Monaco should be fine.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 11, 2024
@davidegiacometti davidegiacometti added Help Wanted We encourage anyone to jump in on these and submit a PR. and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels Dec 11, 2024
@github-project-automation github-project-automation bot moved this to ⚠️Needs Walkthrough in 3. Help Wanted Dec 11, 2024
@asif4318 asif4318 mentioned this issue Dec 21, 2024
Open
@htcfreek
Copy link
Collaborator

@asif4318
Your contribution is welcome and thank you for your work on this. Feel free to open a PR. If you have any further questions don't worry to ask them.

Please update the json file according to the drv docs for adding the extension.

@htcfreek htcfreek added the Status-In progress This issue or work-item is under development label Dec 21, 2024
@asif4318 asif4318 mentioned this issue Dec 21, 2024
Merged
11 tasks
@asif4318
Copy link
Contributor

Just created the initial pull request to add .resx and .resw support

@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Jan 8, 2025
@jaimecbernardo jaimecbernardo added this to the PowerToys 0.88 milestone Jan 8, 2025
@github-project-automation github-project-automation bot moved this from ⚠️Needs Walkthrough to ✅Done in 3. Help Wanted Feb 4, 2025
@cinnamon-msft cinnamon-msft added Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete. and removed Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-File Explorer Power Toys that touch explorer like Preview Pane Product-Peek Refers to Peek Powertoys Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete.
Projects
3. Help Wanted
Status: ✅Done
5. Needs Attention
Status: Done
Milestone
PowerToys 0.88
Development

No branches or pull requests
6 participants
@crutkas @davidegiacometti @jaimecbernardo @cinnamon-msft @htcfreek @asif4318