Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ColorPicker] On black background the black colour preview is not good visible #7283

Closed
htcfreek opened this issue Oct 14, 2020 · 8 comments
Closed

[ColorPicker] On black background the black colour preview is not good visible #7283

htcfreek opened this issue Oct 14, 2020 · 8 comments
Labels
Issue-Bug Something isn't working Product-Color Picker All things around the Color Picker utility Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented Oct 14, 2020 •
edited
Loading

ℹ Computer information

  • PowerToys version: 0.23.2
  • PowerToy Utility: ColorPicker
  • Running PowerToys as Admin: no
  • Windows build number: 19041.508

📝 Provide detailed reproduction steps (if any)

  1. Start color picker
  2. pick black color on black window

✔️ Expected result

The color preview has an white border.

❌ Actual result

The color preview has an black border and is not good visible.

📷 Screenshots

✔️ Expected result
image

❌ Actual result
image
@htcfreek htcfreek added the Issue-Bug Something isn't working label Oct 14, 2020
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Oct 14, 2020
@htcfreek htcfreek added the Product-Color Picker All things around the Color Picker utility label Oct 14, 2020
@ghost
Copy link

ghost commented Oct 14, 2020

@htcfreek locking good?

@htcfreek
Copy link
Collaborator Author

@htcfreek locking good?

What do you mean?

@ghost
Copy link

ghost commented Oct 14, 2020

The title says locking good. You might have meant "looking good"

@htcfreek htcfreek changed the title [ColorPicker] On black background the a black color is not locking good [ColorPicker] On black background the a black color is not looking good Oct 14, 2020
@htcfreek htcfreek changed the title [ColorPicker] On black background the a black color is not looking good [ColorPicker] On black background the black colour preview is not good visible Oct 14, 2020
@niels9001
Copy link
Contributor

Yeah, I think we need to take the same approach as PowerToys Run and provide a 1px border.

@niels9001 niels9001 mentioned this issue Oct 14, 2020
Closed
@htcfreek
Copy link
Collaborator Author

Yeah, I think we need to take the same approach as PowerToys Run and provide a 1px border.

Sounds good, @niels9001. 👍

@crutkas
Copy link
Member

crutkas commented Oct 19, 2020

@niels9001, does #5379 address this?

@niels9001
Copy link
Contributor

@crutkas #7290 will take care of this. And will come in together with #5379.

@crutkas
Copy link
Member

crutkas commented Oct 19, 2020

ok, lets please track this in #7290 then.

@crutkas crutkas closed this as completed Oct 19, 2020
@crutkas crutkas added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug Something isn't working Product-Color Picker All things around the Color Picker utility Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crutkas @niels9001 @htcfreek