Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] Support for deep-linking #7408

Closed
niels9001 opened this issue Oct 20, 2020 · 16 comments
Closed

[Settings] Support for deep-linking #7408

niels9001 opened this issue Oct 20, 2020 · 16 comments
Assignees
Labels
Area-OOBE First time run experience for users Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@niels9001
Copy link
Contributor

This was discussed with @martinchrzan and @crutkas. It would be nice to have deep-linking support to specific Settings pages. Not entirely sure if this is already supported.

This is helpful for the UX of modules (such as FancyZones editor or ColorPicker) to quickly launch into the right settings page. As a fall-back, it should open the default tab (General)

@martinchrzan @crutkas please chime in with any technical requirements!

image


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Oct 20, 2020
@martinchrzan
Copy link
Contributor

We need to review requirements in settings entry point were it requires to be started from the runner, not as a standalone application, or provide easy way for modules to ask runner to open settings window
Microsoft.PowerToys.Settings.UI.Runner - Program.cs

Regarding opening specific page, it should be just a matter of providing some extra parameter when starting settings ui process

@martinchrzan martinchrzan added the Product-Settings The standalone PowerToys Settings application label Oct 20, 2020
@crutkas
Copy link
Member

crutkas commented Oct 20, 2020

My gut says this will be needed for OOBE.

@crutkas crutkas added this to the 2020 Stability Release milestone Oct 20, 2020
@crutkas crutkas added Area-OOBE First time run experience for users and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 20, 2020
@martinchrzan martinchrzan mentioned this issue Oct 30, 2020
5 tasks
@htcfreek
Copy link
Collaborator

This would be a nice feature for IMAGE RESIZER too.

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Nov 10, 2020

#1053 and #888

@Jay-o-Way

This comment has been minimized.

@niels9001
Copy link
Contributor Author

We can only launch it from OOBE. Not yet ready for adding this to all modules.

@htcfreek
Copy link
Collaborator

ping @niels9001: Implementation is in progress.

@htcfreek
Copy link
Collaborator

ping @niels9001: Implementation is in progress.

For specification: The implementation of deep-linking parameter in runner.exe.

@franky920920
Copy link
Contributor

Another suggestion: Get a custom protocol for PowerToys.
For example, FeedBack Hub got feedback-hub:// as protocol, we can have powertoys:// or something as a custom protocol for PT.

I could open another issue for this if required.

@stefansjfw stefansjfw added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Sep 29, 2021
@crutkas crutkas removed the Status-In progress This issue or work-item is under development label Oct 5, 2021
@dedavis6797
Copy link
Contributor

Resolved with v0.49.0. Thanks @niels9001!

@franky920920
Copy link
Contributor

@niels9001 I just found out we do have the custom scheme powertoys: like powertoys://open_settings/ which we had in updateUtils.

L"powertoys://update_now/" },

Would this be better than PowerToys.exe --open-settings=FancyZones if we can do powertoys://fancyzones/?

@niels9001
Copy link
Contributor Author

@niels9001 I just found out we do have the custom scheme powertoys: like powertoys://open_settings/ which we had in updateUtils.

L"powertoys://update_now/" },

Would this be better than PowerToys.exe --open-settings=FancyZones if we can do powertoys://fancyzones/?

@stefansjfw knows more about this stuff :)

@stefansjfw
Copy link
Collaborator

It would be cleaner that way indeed. However, we might want to keep powertoys://<module_name> for launching modules. Maybe we can use something like powertoys://open_settings/<module_name> if possible..

@htcfreek
Copy link
Collaborator

htcfreek commented Nov 1, 2021

It would be cleaner that way indeed. However, we might want to keep powertoys://<module_name> for launching modules. Maybe we can use something like powertoys://open_settings/<module_name> if possible..

why not powertoys:<module_name> and powertoys-settings:<page_name>

@stefansjfw
Copy link
Collaborator

why not powertoys:<module_name> and powertoys-settings/<page_name>

Even better :)

@crutkas
Copy link
Member

crutkas commented Nov 1, 2021

I think for the most part, this is a PT feature only. No one has asked for this outside of core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-OOBE First time run experience for users Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

8 participants