Report Syntax Errors in JSDocs Type Annotations

[mjbvz]

From microsoft/vscode#18229

TypeScript Version: 2.2.0-dev.20170109

Code
In a JS file:

/**
 * @param {(x)=>void} x 
 **/
function foo(x) { }

Expected behavior:
Reports a syntax error when trying to parse the JSDoc type annotation

Actual behavior:
No error reported. x has any type

[mhegazy]

Also related to #6802

[ghost]

This is more important now that we have @ts-check. Although turning on --noImplicitAny will tell you when you got a parse error.
Note: typeof foo and X & Y currently don't parse!

[mhegazy]

@sandersn, we also need to ensure that applicable quick fixes are working correctly in JSDoc, e.g. #15852

[ghost]

Note: fixSpelling.ts would need to be updated so that getTokenAtPosition uses /*includeJsDocComment*/ true. (But that alone wouldn't be sufficent.)

[sandersn]

@mhegazy @andy-ms that quick fix is for a semantic error. That's a separate issue from this one which reports syntax errors. I'll re-open #15852 to track that.

You're not talking about the quick fix "Disable checking for this file", right?

[sandersn]

Fix is up at #16156

[ghost]

Just got tripped up by this:

// @ts-check

/** @typedef Foo {number} */

/** @type Foo */
const x = "";

This isn't an error today. Could we report an error on a @typedef tag where we didn't parse any type?

[Jessidhia]

The error there is actually on the @type tag rather than the @typedef. But yes, sounds reasonable to raise an error.

[ghost]

@Kovensky Thanks, that is actually 2 errors in one. #16946 #16947