Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing types doesn't trigger an error in checkJs #22159

Closed
DanielRosenwasser opened this issue Feb 23, 2018 · 1 comment · Fixed by #49580
Closed

Importing types doesn't trigger an error in checkJs #22159

DanielRosenwasser opened this issue Feb 23, 2018 · 1 comment · Fixed by #49580
Assignees
@andrewbranch
Labels
Bug A bug in TypeScript Domain: JavaScript The issue relates to JavaScript specifically Effort: Casual Good issue if you're already used to contributing to the codebase. Harder than "good first issue". Fix Available A PR has been opened for this issue Help Wanted You can do this
Milestone
TypeScript 4.8.0

Comments

@DanielRosenwasser
Copy link
Member 

// ./a.ts
export type Hello = string;
import { Hello } from "./a";

Expected: Error: Types cannot be imported in a JavaScript file.
Actual: No error.
@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Salsa labels Feb 23, 2018
@mhegazy mhegazy added the Help Wanted You can do this label Mar 9, 2018
@mhegazy mhegazy added this to the Community milestone Mar 9, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Mar 9, 2018

PRs welcomed.

@weswigham weswigham added Domain: JavaScript The issue relates to JavaScript specifically and removed Domain: JavaScript The issue relates to JavaScript specifically Salsa labels Nov 29, 2018
@RyanCavanaugh RyanCavanaugh modified the milestones: Community, Backlog Mar 7, 2019
@DanielRosenwasser DanielRosenwasser mentioned this issue Apr 6, 2022
Closed
@DanielRosenwasser DanielRosenwasser added the Effort: Casual Good issue if you're already used to contributing to the codebase. Harder than "good first issue". label Apr 6, 2022
@DanielRosenwasser DanielRosenwasser mentioned this issue Jun 8, 2022
Closed
@andrewbranch andrewbranch mentioned this issue Jun 16, 2022
Merged
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewbranch andrewbranch

Labels
Bug A bug in TypeScript Domain: JavaScript The issue relates to JavaScript specifically Effort: Casual Good issue if you're already used to contributing to the codebase. Harder than "good first issue". Fix Available A PR has been opened for this issue Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 4.8.0
Development

Successfully merging a pull request may close this issue.

Add error when importing/exporting types in JS files andrewbranch/TypeScript
6 participants
@DanielRosenwasser @weswigham @andrewbranch @RyanCavanaugh @mhegazy @typescript-bot